Skip to content

fix: "Copy Image", "Open Image", "Save Image", "Open in Mask Editor" missing from context menu on SaveImage vue node #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
christian-byrne wants to merge 14 commits into
base: main
Choose a base branch
from
+89 −13
Draft

fix: "Copy Image", "Open Image", "Save Image", "Open in Mask Editor" missing from context menu on SaveImage vue node #7416

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
54c865e
assign node images for backwards compat
christian-byrne Dec 12, 2025
1311d3b
simplify
christian-byrne Dec 12, 2025
db7beb6
[automated] Update test expectations
invalid-email-address Dec 12, 2025
9d4974e
fix: sync node.imgs in Vue nodes for Copy Image compatibility
christian-byrne Dec 13, 2025
aa47ed3
Merge branch 'main' into image-output-backwards-compat
christian-byrne Dec 13, 2025
7049946
fix: use combo widget instead of drag-drop in mask editor test
christian-byrne Dec 13, 2025
9ffced4
fix: use existing workflow image instead of widget interaction
christian-byrne Dec 13, 2025
9a9b3f2
refactor: move node.imgs sync from component to store
christian-byrne Dec 13, 2025
45ec11c
fix: only sync node.imgs in Vue nodes mode
christian-byrne Dec 13, 2025
62d278c
fix: add error handling and race condition guard to syncNodeImgs
christian-byrne Dec 13, 2025
b93c7a5
fix: add missing afterEach import
christian-byrne Dec 13, 2025
cd486a3
fix: zoom out in mask editor test to keep toolbox in viewport
christian-byrne Dec 13, 2025
21aeb5a
fix: use toBeHidden and getByLabel in mask editor test
christian-byrne Dec 14, 2025
ce9beb5
fix: zoom out more in mask editor test
christian-byrne Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: only sync node.imgs in Vue nodes mode
  • Loading branch information
@christian-byrne
christian-byrne committed Dec 13, 2025
commit 45ec11cdbe621ae4511c48d63d983a5e74de6604
3 changes: 3 additions & 0 deletions src/stores/imagePreviewStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useTimeoutFn } from '@vueuse/core'
import { defineStore } from 'pinia'
import { ref } from 'vue'

import { LiteGraph } from '@/lib/litegraph/src/litegraph'
import type { LGraphNode, SubgraphNode } from '@/lib/litegraph/src/litegraph'
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
import type {
Expand Down Expand Up @@ -163,8 +164,10 @@ export const useNodeOutputStore = defineStore('nodeOutput', () => {

/**
* Sync node.imgs for backwards compatibility with legacy systems (e.g., Copy Image).
* Only needed in Vue nodes mode since legacy nodes already populate node.imgs.
*/
function syncNodeImgs(nodeLocatorId: NodeLocatorId, imageUrls: string[]) {
if (!LiteGraph.vueNodesMode) return
if (!imageUrls.length) return
const nodeId = nodeLocatorIdToNodeId(nodeLocatorId)
if (nodeId === null) return
Expand Down
Loading