-
Notifications
You must be signed in to change notification settings - Fork 449
fix: "Copy Image", "Open Image", "Save Image", "Open in Mask Editor" missing from context menu on SaveImage vue node #7416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
14
commits into
main
Choose a base branch
from
image-output-backwards-compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
54c865e
assign node images for backwards compat
christian-byrne 1311d3b
simplify
christian-byrne db7beb6
[automated] Update test expectations
invalid-email-address 9d4974e
fix: sync node.imgs in Vue nodes for Copy Image compatibility
christian-byrne aa47ed3
Merge branch 'main' into image-output-backwards-compat
christian-byrne 7049946
fix: use combo widget instead of drag-drop in mask editor test
christian-byrne 9ffced4
fix: use existing workflow image instead of widget interaction
christian-byrne 9a9b3f2
refactor: move node.imgs sync from component to store
christian-byrne 45ec11c
fix: only sync node.imgs in Vue nodes mode
christian-byrne 62d278c
fix: add error handling and race condition guard to syncNodeImgs
christian-byrne b93c7a5
fix: add missing afterEach import
christian-byrne cd486a3
fix: zoom out in mask editor test to keep toolbox in viewport
christian-byrne 21aeb5a
fix: use toBeHidden and getByLabel in mask editor test
christian-byrne ce9beb5
fix: zoom out more in mask editor test
christian-byrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: move node.imgs sync from component to store
Move syncNodeImgs logic from ImagePreview.vue to imagePreviewStore.ts for proper separation of concerns. Store handles backwards compatibility sync when setting node outputs.
- Loading branch information
commit 9a9b3f286bd92f8677b174a8ed8c17c090e8c51e
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.