Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix control popover not updating icon
  • Loading branch information
AustinMroz committed Dec 16, 2025
commit bbf6018cf8fbd53540d5250d1be41edb59624b80
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
<script setup lang="ts" generic="T extends WidgetValue">
import Button from 'primevue/button'
import { computed, defineAsyncComponent, ref } from 'vue'
import { computed, defineAsyncComponent, ref, watch } from 'vue'
import type { Component } from 'vue'

import type {
ControlOptions,
SimplifiedControlWidget,
WidgetValue
} from '@/types/simplifiedWidget'
Expand All @@ -18,12 +17,14 @@ const props = defineProps<{
component: Component
}>()

const modelValue = defineModel<number>({ default: 0 })
const modelValue = defineModel<T>()

const popover = ref()

const controlModel = ref(props.widget.controlWidget.value)

const controlButtonIcon = computed(() => {
switch (props.widget.controlWidget.value) {
switch (controlModel.value) {
case 'increment':
return 'pi pi-plus'
case 'decrement':
Expand All @@ -35,9 +36,7 @@ const controlButtonIcon = computed(() => {
}
})

const setControlMode = (mode: ControlOptions) => {
props.widget.controlWidget.update(mode)
}
watch(controlModel, props.widget.controlWidget.update)

const togglePopover = (event: Event) => {
popover.value.toggle(event)
Expand All @@ -56,10 +55,6 @@ const togglePopover = (event: Event) => {
<i :class="`${controlButtonIcon} text-blue-100 text-xs size-3.5`" />
</Button>
</component>
<ValueControlPopover
ref="popover"
:control-mode="widget.controlWidget"
@update:control-mode="setControlMode"
/>
<ValueControlPopover ref="popover" v-model="controlModel" />
</div>
</template>