Skip to content

Fix doubled control application #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AustinMroz merged 6 commits into from
Dec 17, 2025
Merged

Fix doubled control application #7550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
502d8eb
Fix doubled control application, pruning
AustinMroz Dec 16, 2025
78b420e
Add missing models
AustinMroz Dec 16, 2025
d603512
Nits
AustinMroz Dec 16, 2025
22c28c1
Fix playwright test
AustinMroz Dec 16, 2025
bbf6018
Fix control popover not updating icon
AustinMroz Dec 16, 2025
f0b4762
Fix control widget display on combos
AustinMroz Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix control widget display on combos 
Was missed
  • Loading branch information
@AustinMroz
AustinMroz committed Dec 16, 2025
commit f0b476226086a981e75ba010a7aa9762b034a299
2 changes: 2 additions & 0 deletions src/extensions/core/widgetInputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ export class PrimitiveNode extends LGraphNode {
undefined,
inputData
)
if (this.widgets?.[1]) widget.linkedWidgets = [this.widgets[1]]

let filter = this.widgets_values?.[2]
if (filter && this.widgets && this.widgets.length === 3) {
this.widgets[2].value = filter
Expand Down
5 changes: 4 additions & 1 deletion src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@
:pt="{
option: 'text-xs',
dropdown: 'w-8',
label: 'truncate min-w-[4ch]',
label: cn('truncate min-w-[4ch]', $slots.default && 'mr-5'),
overlay: 'w-fit min-w-full'
}"
data-capture-wheel="true"
/>
<div class="absolute top-5 right-8 h-4 w-7 -translate-y-4/5 flex">
<slot />
</div>
Comment on lines +21 to +23
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

find src -name "WidgetSelectDefault.vue" -type f

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 145

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 2192

🏁 Script executed:

find src -name "WidgetLayoutField.vue" -type f

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 150

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/layout/WidgetLayoutField.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1189

🏁 Script executed:

grep -r "WidgetSelectDefault" src --include="*.vue" --include="*.ts" -l | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 138

🏁 Script executed:

rg "overflow-hidden" src/renderer/extensions/vueNodes/widgets --type vue -A 2 -B 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 97

🏁 Script executed:

rg "overflow-hidden" src/renderer/extensions/vueNodes/widgets -A 2 -B 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 2363

🏁 Script executed:

find src/renderer/extensions/vueNodes/widgets -type f -name "*.vue" | xargs grep -l "overflow"

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 537

🏁 Script executed:

find src -name "*.vue" -path "*vueNodes*" | xargs grep -l "WidgetLayoutField" | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 449

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/WidgetSelect.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3699

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/WidgetWithControl.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1612

🏁 Script executed:

rg "class.*relative" src/renderer/extensions/vueNodes/widgets/components/layout -A 3

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 477

🏁 Script executed:

rg "overflow-hidden" src/renderer/extensions/vueNodes --type vue | grep -E "(WidgetLayout|Select)" | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 97

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/ValueControlPopover.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3471

🏁 Script executed:

rg "Teleport" src/renderer/extensions/vueNodes/widgets --include="*.vue" | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 511

🏁 Script executed:

rg "WidgetSelectDefault\|absolute.*top-5.*right-8" src --include="*.vue" -A 3 -B 3

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 511

🏁 Script executed:

rg "Teleport" src/renderer/extensions/vueNodes/widgets -t vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 97

🏁 Script executed:

rg "absolute.*top-5.*right-8" src -t vue -A 3 -B 3

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 97

🏁 Script executed:

find src/renderer/extensions/vueNodes/widgets -name "*.vue" | xargs grep -l "Teleport"

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 54

🏁 Script executed:

find src -name "*.vue" | xargs grep "absolute.*top-5.*right-8" -B 3 -A 3

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1527

🏁 Script executed:

find src/renderer/extensions/vueNodes -name "*.vue" | xargs grep -l "WidgetInputNumberInput\|WidgetSelectDefault" | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 212

🏁 Script executed:

find src/renderer -path "*vueNodes*" -name "*.vue" | xargs grep "overflow-hidden" -l

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 476

🏁 Script executed:

find src -name "NodeComponentPanelWidget.vue" -o -name "NodeComponentPanel.vue" -o -name "*Node*.vue" | grep -E "vueNodes.*components" | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 489

🏁 Script executed:

find src/renderer/extensions/vueNodes -maxdepth 2 -name "*.vue" | xargs grep -l "WidgetSelectDefault\|WidgetInputNumberInput"

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 54

🏁 Script executed:

cat src/renderer/extensions/vueNodes/components/NodeWidgets.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 6524

🏁 Script executed:

cat src/renderer/extensions/vueNodes/components/NodeContent.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1617

🏁 Script executed:

find src -name "*.vue" | xargs grep -l "grid-cols-subgrid" | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 344

🏁 Script executed:

grep -r "position.*context\|Teleport" src/renderer/extensions/vueNodes --include="*.ts" --include="*.vue" | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52

🏁 Script executed:

rg "z-\[" src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52

🏁 Script executed:

cat src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumber.vue | head -50

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1133

The absolute positioning with relative parent context is correctly implemented and consistent across similar widget components. Parent containers don't use overflow: hidden, so clipping isn't a concern. However, verify that the control button's z-index doesn't conflict with the Select dropdown overlay when opened, and test dropdown interactions in constrained viewport scenarios to ensure the button remains accessible.

🤖 Prompt for AI Agents 
In src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue
around lines 21 to 23, the absolute-positioned control button may conflict with
the Select dropdown overlay; ensure the button's stacking context doesn't cover
or get covered by the dropdown by adding an explicit z-index (or adjusting the
dropdown's z-index) on the button container, and if necessary create a new
stacking context (e.g., by adding a positioned ancestor or isolation) so the
dropdown overlay sits above the button; after the change, test dropdown
interactions in constrained viewports and when the dropdown is open to confirm
the button remains accessible and not clipped or blocking clicks.

</WidgetLayoutField>
</template>

Expand Down
Loading