-
Notifications
You must be signed in to change notification settings - Fork 363
Add support for partial properties for [ObservableProperty] #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
11d15c9
Add blank 'Roslyn4110' project
Sergio0694 e27359f
Fix naming conventions for all Roslyn projects
Sergio0694 a67a31d
Add 'global.json' file
Sergio0694 9c9061d
Update .targets for Roslyn setup
Sergio0694 f4fdb27
Pack new source generator in MVVM Toolkit
Sergio0694 c8e794b
Add logic to match partial properties
Sergio0694 76264f7
Update the generator to also work on properties
Sergio0694 3df53f3
Add 'RequiresCSharpLanguageVersionPreviewAnalyzer'
Sergio0694 fff5f91
Suppress warnings about removed rules
Sergio0694 41dc834
Add blank test project for new generator
Sergio0694 34a7c6f
Update '[ObservableProperty]' attribute
Sergio0694 bbd59ec
Add unit tests for new analyzer
Sergio0694 f970ba6
Move forwarded attributes gathering to helper
Sergio0694 e5b2802
Gather accessibility information from nodes
Sergio0694 17263fe
Generalizing the generated accessibility modifiers
Sergio0694 5f2ffcf
Don't emit an error for collisions for properties
Sergio0694 46d03e8
Update generation to account for properties
Sergio0694 52ad254
Fix a generator crash when used on properties
Sergio0694 8ca2f3c
Omit implicit accessibility modifiers
Sergio0694 db221ed
Update the targets of additional attributes
Sergio0694 f9f7771
Fix handling notify data error info
Sergio0694 5d37b73
Fix nullability for generated partial properties
Sergio0694 aabcd15
Add initial codegen tests for partial properties
Sergio0694 62c06f1
Add 'UseObservablePropertyOnPartialPropertyAnalyzer'
Sergio0694 6342b83
Add unit tests for new analyzer
Sergio0694 efa90a3
Add 'InvalidPropertyLevelObservablePropertyAttributeAnalyzer'
Sergio0694 767c05b
Add 'UnsupportedRoslynVersionForPartialPropertyAnalyzer'
Sergio0694 eea59fd
Fix handling of 'private protected' accessors
Sergio0694 162bab5
Add unit tests for invalid property declarations
Sergio0694 5e02b9a
Add 'UsePartialPropertyForObservablePropertyCodeFixer'
Sergio0694 9ba8f27
Add new helper for testing code fixers
Sergio0694 b98a658
Add unit test for new code fixer
Sergio0694 8cdebe0
Fix attributes handling, add unit tests
Sergio0694 e6a5c09
Add unit tests for comments in code fixer
Sergio0694 00ebe42
Support updating field references as well
Sergio0694 3453824
Improve messages in diagnostics when emitted on properties
Sergio0694 7b402b6
Add workaround for older Roslyn versions
Sergio0694 ca5d9dd
Fix a unit test on .NET Framework
Sergio0694 648788c
Fix last remaining unit test, and test regex
Sergio0694 9c9ff44
Set version.json to 8.4.0
Sergio0694 f75edab
Don't suggest partial properties for static fields
Sergio0694 0a81f27
Support field initializers in code fixer
Sergio0694 a7840b2
Don't run analyzers on generated code
Sergio0694 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update '[ObservableProperty]' attribute
- Loading branch information
commit 34a7c6f6080f092fac60df604f2eb79e7cae9fff
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: should "name" here also have a capital, since it's now a property? and the generated code below also seems to have a capital?