Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
11d15c9
Add blank 'Roslyn4110' project
Sergio0694 Oct 23, 2024
e27359f
Fix naming conventions for all Roslyn projects
Sergio0694 Oct 23, 2024
a67a31d
Add 'global.json' file
Sergio0694 Oct 23, 2024
9c9061d
Update .targets for Roslyn setup
Sergio0694 Oct 23, 2024
f4fdb27
Pack new source generator in MVVM Toolkit
Sergio0694 Oct 23, 2024
c8e794b
Add logic to match partial properties
Sergio0694 Oct 23, 2024
76264f7
Update the generator to also work on properties
Sergio0694 Oct 23, 2024
3df53f3
Add 'RequiresCSharpLanguageVersionPreviewAnalyzer'
Sergio0694 Oct 23, 2024
fff5f91
Suppress warnings about removed rules
Sergio0694 Oct 23, 2024
41dc834
Add blank test project for new generator
Sergio0694 Oct 23, 2024
34a7c6f
Update '[ObservableProperty]' attribute
Sergio0694 Oct 23, 2024
bbd59ec
Add unit tests for new analyzer
Sergio0694 Oct 23, 2024
f970ba6
Move forwarded attributes gathering to helper
Sergio0694 Oct 24, 2024
e5b2802
Gather accessibility information from nodes
Sergio0694 Oct 24, 2024
17263fe
Generalizing the generated accessibility modifiers
Sergio0694 Oct 24, 2024
5f2ffcf
Don't emit an error for collisions for properties
Sergio0694 Oct 24, 2024
46d03e8
Update generation to account for properties
Sergio0694 Oct 24, 2024
52ad254
Fix a generator crash when used on properties
Sergio0694 Oct 24, 2024
8ca2f3c
Omit implicit accessibility modifiers
Sergio0694 Oct 24, 2024
db221ed
Update the targets of additional attributes
Sergio0694 Oct 24, 2024
f9f7771
Fix handling notify data error info
Sergio0694 Oct 24, 2024
5d37b73
Fix nullability for generated partial properties
Sergio0694 Oct 24, 2024
aabcd15
Add initial codegen tests for partial properties
Sergio0694 Oct 24, 2024
62c06f1
Add 'UseObservablePropertyOnPartialPropertyAnalyzer'
Sergio0694 Oct 24, 2024
6342b83
Add unit tests for new analyzer
Sergio0694 Oct 24, 2024
efa90a3
Add 'InvalidPropertyLevelObservablePropertyAttributeAnalyzer'
Sergio0694 Oct 24, 2024
767c05b
Add 'UnsupportedRoslynVersionForPartialPropertyAnalyzer'
Sergio0694 Oct 24, 2024
eea59fd
Fix handling of 'private protected' accessors
Sergio0694 Oct 24, 2024
162bab5
Add unit tests for invalid property declarations
Sergio0694 Oct 24, 2024
5e02b9a
Add 'UsePartialPropertyForObservablePropertyCodeFixer'
Sergio0694 Oct 25, 2024
9ba8f27
Add new helper for testing code fixers
Sergio0694 Oct 25, 2024
b98a658
Add unit test for new code fixer
Sergio0694 Oct 25, 2024
8cdebe0
Fix attributes handling, add unit tests
Sergio0694 Oct 25, 2024
e6a5c09
Add unit tests for comments in code fixer
Sergio0694 Oct 25, 2024
00ebe42
Support updating field references as well
Sergio0694 Oct 25, 2024
3453824
Improve messages in diagnostics when emitted on properties
Sergio0694 Oct 25, 2024
7b402b6
Add workaround for older Roslyn versions
Sergio0694 Oct 25, 2024
ca5d9dd
Fix a unit test on .NET Framework
Sergio0694 Oct 25, 2024
648788c
Fix last remaining unit test, and test regex
Sergio0694 Oct 25, 2024
9c9ff44
Set version.json to 8.4.0
Sergio0694 Oct 25, 2024
f75edab
Don't suggest partial properties for static fields
Sergio0694 Oct 25, 2024
0a81f27
Support field initializers in code fixer
Sergio0694 Oct 25, 2024
a7840b2
Don't run analyzers on generated code
Sergio0694 Oct 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add 'UnsupportedRoslynVersionForPartialPropertyAnalyzer'
  • Loading branch information
Sergio0694 committed Oct 24, 2024
commit 767c05b2552f0abb8ddc1541c266f6469b7fd106
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,4 @@ Rule ID | Category | Severity | Notes
MVVMTK0041 | CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator | Error | See https://aka.ms/mvvmtoolkit/errors/mvvmtk0041
MVVMTK0042 | CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator | Info | See https://aka.ms/mvvmtoolkit/errors/mvvmtk0042
MVVMTK0043| CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator | Error | See https://aka.ms/mvvmtoolkit/errors/mvvmtk0043
MVVMTK0044| CommunityToolkit.Mvvm.SourceGenerators.ObservablePropertyGenerator | Error | See https://aka.ms/mvvmtoolkit/errors/mvvmtk0043
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\ClassUsingAttributeInsteadOfInheritanceAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\FieldWithOrphanedDependentObservablePropertyAttributesAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\FieldReferenceForObservablePropertyFieldAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\UnsupportedRoslynVersionForPartialPropertyAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\RequiresCSharpLanguageVersionPreviewAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\InvalidPropertyLevelObservablePropertyAttributeAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Diagnostics\Analyzers\UseObservablePropertyOnPartialPropertyAnalyzer.cs" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

#if !ROSLYN_4_11_0_OR_GREATER

using System.Collections.Immutable;
using CommunityToolkit.Mvvm.SourceGenerators.Extensions;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.Diagnostics;
using static CommunityToolkit.Mvvm.SourceGenerators.Diagnostics.DiagnosticDescriptors;

namespace CommunityToolkit.Mvvm.SourceGenerators;

/// <summary>
/// A diagnostic analyzer that generates an error whenever <c>[ObservableProperty]</c> is used on a property, if the Roslyn version in use is not high enough.
/// </summary>
[DiagnosticAnalyzer(LanguageNames.CSharp)]
public sealed class UnsupportedRoslynVersionForPartialPropertyAnalyzer : DiagnosticAnalyzer
{
/// <inheritdoc/>
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } = ImmutableArray.Create(UnsupportedRoslynVersionForObservablePartialPropertySupport);

/// <inheritdoc/>
public override void Initialize(AnalysisContext context)
{
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
context.EnableConcurrentExecution();

context.RegisterCompilationStartAction(static context =>
{
// Get the symbol for [ObservableProperty]
if (context.Compilation.GetTypeByMetadataName("CommunityToolkit.Mvvm.ComponentModel.ObservablePropertyAttribute") is not INamedTypeSymbol observablePropertySymbol)
{
return;
}

context.RegisterSymbolAction(context =>
{
// We're intentionally only looking for properties here
if (context.Symbol is not IPropertySymbol propertySymbol)
{
return;
}

// If the property has [ObservableProperty], emit an error in all cases
if (propertySymbol.TryGetAttributeWithType(observablePropertySymbol, out AttributeData? observablePropertyAttribute))
{
context.ReportDiagnostic(Diagnostic.Create(
UnsupportedRoslynVersionForObservablePartialPropertySupport,
observablePropertyAttribute.GetLocation(),
propertySymbol.ContainingType,
propertySymbol));
}
}, SymbolKind.Property);
});
}
}

#endif
Original file line number Diff line number Diff line change
Expand Up @@ -727,4 +727,20 @@ internal static class DiagnosticDescriptors
isEnabledByDefault: true,
description: "Properties annotated with [ObservableProperty] must be partial properties with a getter and a setter that is not init-only.",
helpLinkUri: "https://aka.ms/mvvmtoolkit/errors/mvvmtk0043");

/// <summary>
/// Gets a <see cref="DiagnosticDescriptor"/> indicating when <c>[ObservableProperty]</c> is applied to a property when an unsupported version of Roslyn is used.
/// <para>
/// Format: <c>"The property {0}.{1} cannot be used to generate an observable property, as the current Roslyn version being used is not high enough (remove [ObservableProperty] or target a field instead, or upgrade to at least Visual Studio 2022 version 17.12 and the .NET 9 SDK)"</c>.
/// </para>
/// </summary>
public static readonly DiagnosticDescriptor UnsupportedRoslynVersionForObservablePartialPropertySupport = new DiagnosticDescriptor(
id: "MVVMTK0044",
title: "Unsupported Roslyn version for using [ObservableProperty] on partial properties",
messageFormat: "The property {0}.{1} cannot be used to generate an observable property, as the current Roslyn version being used is not high enough (remove [ObservableProperty] or target a field instead, or upgrade to at least Visual Studio 2022 version 17.12 and the .NET 9 SDK)",
category: typeof(ObservablePropertyGenerator).FullName,
defaultSeverity: DiagnosticSeverity.Error,
isEnabledByDefault: true,
description: "Using [ObservableProperty] with (partial) properties requires a higher version of Roslyn (remove [ObservableProperty] or target a field instead, or upgrade to at least Visual Studio 2022 version 17.12 and the .NET 9 SDK).",
helpLinkUri: "https://aka.ms/mvvmtoolkit/errors/mvvmtk0044");
}