Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
6461120
docs: add rewrite architecture records
xz-dev Jun 22, 2026
9527287
chore: add rewrite agent guardrails
xz-dev Jun 22, 2026
ae0d72c
feat(app): add Flutter shell scaffold
xz-dev Jun 22, 2026
4756f7c
feat(getter): wire package-centric getter submodule
xz-dev Jun 22, 2026
a5730a9
ci: add rewrite validation workflow
xz-dev Jun 22, 2026
59c1a0d
fix(getter): keep Android proxy off Lua deps
xz-dev Jun 22, 2026
3201d92
fix(app): use Flutter-compatible Gradle wrapper
xz-dev Jun 22, 2026
35e6c3d
ci: restrict Telegram notifications to master pushes
xz-dev Jun 22, 2026
80e1eb6
fix(app): use Flutter-compatible AGP
xz-dev Jun 22, 2026
384aee6
docs: add rewrite next-step audit plan
xz-dev Jun 22, 2026
a1c43f4
fix(app): use Flutter-compatible Kotlin plugin
xz-dev Jun 22, 2026
c6838b5
docs: update rewrite next-step completion status
xz-dev Jun 22, 2026
76f771a
feat(app): add getter bridge contract
xz-dev Jun 22, 2026
47f5811
feat(getter): add offline repo validation
xz-dev Jun 22, 2026
0976844
feat(getter): import legacy Room databases
xz-dev Jun 22, 2026
81a5dec
feat(getter): add installed app autogen
xz-dev Jun 22, 2026
8f3ca13
feat(getter): add offline update check
xz-dev Jun 22, 2026
9bb18f2
feat(getter): add offline task lifecycle
xz-dev Jun 23, 2026
1ba7614
feat(app): render getter task DTOs
xz-dev Jun 23, 2026
aed83cb
ci(app): publish Flutter APK artifacts
xz-dev Jun 23, 2026
2e22767
feat(app): add legacy Room migration adapter
xz-dev Jun 23, 2026
39af4c7
feat(app): add Android platform adapter spine
xz-dev Jun 23, 2026
3a5a602
feat(app): add Android installed inventory provider
xz-dev Jun 23, 2026
dd94154
feat(app): bridge installed autogen to Flutter
xz-dev Jun 23, 2026
8a6ac21
feat(app): bridge legacy room import
xz-dev Jun 24, 2026
044ca72
ci: set Android ar for cargo checks
xz-dev Jun 24, 2026
65df6ab
test(app): cover legacy room preparation
xz-dev Jun 24, 2026
c0f6752
test(app): validate native bridge on device
xz-dev Jun 24, 2026
d392b5c
docs(architecture): accept runtime task ADRs
xz-dev Jun 25, 2026
dba34ec
feat(app): bridge runtime task operations
xz-dev Jun 25, 2026
108625a
feat(app): stream runtime notifications
xz-dev Jun 25, 2026
2b98939
docs(todo): update runtime bridge progress
xz-dev Jun 25, 2026
ced8576
feat(app): issue runtime actions from update checks
xz-dev Jun 25, 2026
5061d20
docs(todo): note offline action issuance
xz-dev Jun 25, 2026
71c71c9
docs(lua): document static update candidates
xz-dev Jun 25, 2026
75b9f65
feat(app): issue actions from registered packages
xz-dev Jun 25, 2026
2aad93f
docs(todo): note registered package action issuance
xz-dev Jun 25, 2026
7ebf9be
feat(app): adopt pin version DTOs
xz-dev Jun 25, 2026
c1f7126
feat(app): add typed runtime task APIs
xz-dev Jun 25, 2026
b2c03b7
chore(app): point CLI debug tasks at runtime script
xz-dev Jun 25, 2026
3897038
refactor(app): drop fake task DTOs from product adapter
xz-dev Jun 25, 2026
dd9115c
docs(lua): describe static mock provider boundary
xz-dev Jun 25, 2026
1530a42
refactor(app): drop CLI fake task adapter APIs
xz-dev Jun 25, 2026
7bcaa0b
ci: install multilib for Android LuaJIT builds
xz-dev Jun 25, 2026
4e6274a
chore(app): update Flutter toolchain baseline
xz-dev Jun 25, 2026
25af79c
feat(app): load snapshots from native getter read model
xz-dev Jun 25, 2026
1a5d822
feat(app): submit update checks to runtime
xz-dev Jun 25, 2026
239f98f
docs(architecture): define provider autogen repository model
xz-dev Jun 26, 2026
4d65323
feat(app): use ADR-0012 autogen repository defaults
xz-dev Jun 26, 2026
03cb206
feat(getter): use package directory discovery
xz-dev Jun 26, 2026
4dea731
feat(app): consume package-directory autogen previews
xz-dev Jun 26, 2026
346636f
feat(getter): evaluate package directories
xz-dev Jun 26, 2026
aa3fdbb
fix(getter): update clippy-clean gitlink
xz-dev Jun 26, 2026
a8739cc
feat(getter): expose package-local file reads
xz-dev Jun 26, 2026
1ce7701
fix(getter): hash package-local file inputs
xz-dev Jun 26, 2026
175ae4c
feat(getter): add provider cache primitives
xz-dev Jun 26, 2026
e0673f2
feat(getter): add F-Droid provider fixtures
xz-dev Jun 26, 2026
1a13cbd
feat(getter): cache F-Droid catalog fixtures
xz-dev Jun 26, 2026
728cff6
feat(getter): add F-Droid autogen CLI slice
xz-dev Jun 27, 2026
dddce32
feat(getter): match F-Droid installed inventory
xz-dev Jun 27, 2026
b35b7c4
feat(getter): add GitHub release fixtures
xz-dev Jun 27, 2026
416075e
refactor(getter): remove flat Lua repository layout
xz-dev Jun 27, 2026
80df257
feat(app): expose F-Droid autogen bridge
xz-dev Jun 27, 2026
eb1719d
feat(getter): add GitHub latest commit fixtures
xz-dev Jun 27, 2026
be6f4b3
test(getter): cover F-Droid luaclass shape
xz-dev Jun 27, 2026
526e5d4
test(getter): cover GitHub luaclass shape
xz-dev Jun 27, 2026
cb74bba
feat(getter): add Lua host binding seam
xz-dev Jun 27, 2026
2f6585e
feat(getter): add dev Lua provider host eval
xz-dev Jun 27, 2026
345ef45
feat(getter): add F-Droid dev Lua provider host eval
xz-dev Jun 27, 2026
4e06159
feat(getter): add builtin luaclass fallback
xz-dev Jun 27, 2026
b8e929a
feat(getter): add Lua HTTP host seam
xz-dev Jun 27, 2026
64e2fb4
feat(getter): add dev provider luaclass modules
xz-dev Jun 27, 2026
dd1c259
feat(getter): add Lua HTTP policy harness
xz-dev Jun 27, 2026
8942c7f
feat(getter): add runtime hook harness
xz-dev Jun 27, 2026
19f2fd9
docs(architecture): design provider host API v1
xz-dev Jun 28, 2026
016f977
feat(getter): add stable provider host harness
xz-dev Jun 28, 2026
561d0e7
feat(getter): store provider response provenance
xz-dev Jun 28, 2026
b20fb0a
feat(getter): promote standard provider luaclasses
xz-dev Jun 28, 2026
c86c894
fix(getter): validate provider endpoint ids
xz-dev Jun 28, 2026
9e2be1e
test(getter): lock fdroid generated script boundary
xz-dev Jun 28, 2026
3b70b92
docs(plan): defer fdroid generated provider adoption
xz-dev Jun 28, 2026
0bb0c77
test(getter): cover configured provider endpoints
xz-dev Jun 28, 2026
236794e
feat(getter): use provider-backed update checks
xz-dev Jun 28, 2026
e1993f2
feat(getter): use F-Droid provider module autogen output
xz-dev Jun 28, 2026
67e99a8
feat(app): add installed F-Droid autogen flow
xz-dev Jun 29, 2026
1f7773b
feat(app): refresh F-Droid catalog cache
xz-dev Jun 29, 2026
4fbb6ca
feat(getter): add GitHub standard module runtime slice
xz-dev Jul 2, 2026
a1cdee6
feat(getter): add GitHub autogen product seam
xz-dev Jul 2, 2026
31ab0f9
feat(getter): add GitHub releases live transport slice
xz-dev Jul 2, 2026
5a380f6
feat(app): add GitHub autogen product bridge
xz-dev Jul 2, 2026
1b49340
feat(app): run getter-owned download bytes
xz-dev Jul 2, 2026
ea26f3e
feat(app): load getter startup snapshot
xz-dev Jul 14, 2026
c1f79c1
docs(cli): document app inspect and check
xz-dev Jul 14, 2026
171fb8e
docs(architecture): define artifact staging and installers
xz-dev Jul 16, 2026
0cd8a4b
feat(app): guide fresh package setup
xz-dev Jul 17, 2026
2369bcc
feat(app): bridge Android APK install preparation
xz-dev Jul 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(app): add getter bridge contract
Add ADR-0007, getter-owned Flutter DTOs, fake and CLI adapters, and a Flutter dev test that exercises a real getter-cli data directory. Wire the integration test into just verify and update the getter submodule to the legacy report-list command.
  • Loading branch information
xz-dev committed Jun 22, 2026
commit 76f771a918c3fd16af84acf1cfb07674f42063aa
3 changes: 2 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ Before coding, every agent MUST read:
6. `docs/architecture/adr/0004-sqlite-main-db-and-cache-db.md`
7. `docs/architecture/adr/0005-lua-package-api.md`
8. `docs/architecture/adr/0006-package-centric-cli-command-contract.md`
9. `docs/app/flutter-ui-feature-parity-and-testing.md`
9. `docs/architecture/adr/0007-flutter-getter-bridge-contract.md`
10. `docs/app/flutter-ui-feature-parity-and-testing.md`

## Core architecture rules

Expand Down
10 changes: 7 additions & 3 deletions app_flutter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,19 @@ This is the new Flutter shell for the UpgradeAll rewrite. It must remain a UI an
## Current slice

- Android application identity: `net.xzos.upgradeall`
- Stable route/action/state keys for widget and future integration tests
- Stable route/action/state keys for widget and future integration/dev tests
- Placeholder routes for apps, repositories, downloads, logs, settings, and legacy migration
- Fake in-memory getter adapter until the Rust getter FFI/RPC binding is wired
- `FakeGetterAdapter` for deterministic widget tests
- `CliGetterAdapter` as a development/integration bridge against the real `getter-cli` JSON envelope

`CliGetterAdapter` is not the final Android production bridge. It exists to keep the getter-owned DTO and error contract executable while the native bridge is designed in ADR-0007.

## Verification

```bash
flutter analyze
flutter test
GETTER_CLI_BIN=/path/to/getter-cli flutter test dev_test/cli_getter_adapter_test.dart
```

From the repository root, `just verify` also runs the Flutter analyzer and widget tests.
From the repository root, `just verify` also runs the Flutter analyzer, widget tests, getter CLI integration/dev test, and Android debug build.
128 changes: 128 additions & 0 deletions app_flutter/dev_test/cli_getter_adapter_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
import 'dart:io';

import 'package:flutter_test/flutter_test.dart';
import 'package:upgradeall/cli_getter_adapter.dart';

void main() {
test('CliGetterAdapter reads real getter repository and tracked state', () {
final getterCli = Platform.environment['GETTER_CLI_BIN'];
if (getterCli == null || getterCli.isEmpty) {
fail('GETTER_CLI_BIN must point to the built getter-cli binary');
}

final temp = Directory.systemTemp.createTempSync('upgradeall-getter-cli-');
addTearDown(() => temp.deleteSync(recursive: true));

final dataDir = Directory('${temp.path}/data')..createSync();
final repoDir = _createFixtureRepository(temp, 'official');
final bundle = _createLegacyBundle(temp);
final adapter =
CliGetterAdapter(executable: getterCli, dataDir: dataDir.path);

adapter.initialize();
_runGetter(getterCli, dataDir.path, <String>[
'repo',
'add',
'official',
repoDir.path,
'--priority',
'0',
]);
_runGetter(getterCli, dataDir.path, <String>[
'legacy',
'import-room-bundle',
bundle.path,
]);

final repositories = adapter.listRepositories();
expect(repositories.map((repo) => repo.id), contains('official'));
expect(
repositories.singleWhere((repo) => repo.id == 'official').priority, 0);

final trackedPackages = adapter.listTrackedPackages();
final tracked = trackedPackages.singleWhere(
(package) => package.id == 'android/org.fdroid.fdroid',
);
expect(tracked.favorite, isTrue);
expect(tracked.ignoredVersion, '1.20.0');
expect(tracked.packageResolution, 'official_repository_package');

final evaluated = adapter.evaluatePackage(
'android/org.fdroid.fdroid',
repositoryId: 'official',
);
expect(evaluated.name, 'F-Droid');
expect(evaluated.repositoryId, 'official');
expect(evaluated.hasFreeNetworkWarning, isTrue);

final reports = adapter.readMigrationReports();
expect(
reports.singleWhere((report) => report.code == 'migration.imported').ok,
isTrue);

final snapshot = adapter.loadSnapshot();
expect(snapshot.status, 'Getter CLI ready');
expect(snapshot.repositories.map((repo) => repo.id), contains('official'));
final app = snapshot.apps.singleWhere(
(app) => app.id == 'android/org.fdroid.fdroid',
);
expect(app.name, 'F-Droid');
expect(app.installedVersion, 'unknown');
expect(app.hasFreeNetworkWarning, isTrue);
});
}

Directory _createFixtureRepository(Directory temp, String repoId) {
final repoDir = Directory('${temp.path}/repo-$repoId')..createSync();
Directory('${repoDir.path}/packages/android').createSync(recursive: true);
Directory('${repoDir.path}/lib').createSync();
Directory('${repoDir.path}/templates').createSync();
File('${repoDir.path}/repo.toml').writeAsStringSync('''
id = "$repoId"
name = "Fixture $repoId"
priority = 0
api_version = "getter.repo.v1"
''');
File('${repoDir.path}/packages/android/org.fdroid.fdroid.lua')
.writeAsStringSync('''
return package_def {
id = "android/org.fdroid.fdroid",
name = "F-Droid",
installed = {
{ kind = "android_package", package_name = "org.fdroid.fdroid" },
},
permissions = { free_network = true },
}
''');
return repoDir;
}

File _createLegacyBundle(Directory temp) {
return File('${temp.path}/legacy-bundle.json')..writeAsStringSync('''
{
"format": "upgradeall-legacy-room-bundle",
"version": 17,
"apps": [
{
"kind": "android",
"installed_id": "org.fdroid.fdroid",
"official_package_available": true,
"ignored_version": "1.20.0",
"favorite": true
}
]
}
''');
}

void _runGetter(String getterCli, String dataDir, List<String> args) {
final result = Process.runSync(
getterCli,
<String>['--data-dir', dataDir, ...args],
);
if (result.exitCode != 0) {
fail('getter ${args.join(' ')} failed with ${result.exitCode}\n'
'stdout:\n${result.stdout}\n'
'stderr:\n${result.stderr}');
}
}
200 changes: 200 additions & 0 deletions app_flutter/lib/cli_getter_adapter.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,200 @@
import 'dart:convert';
import 'dart:io';

import 'getter_adapter.dart';

class CliGetterAdapter implements GetterAdapter {
const CliGetterAdapter({
required this.executable,
required this.dataDir,
this.environment = const <String, String>{},
});

final String executable;
final String dataDir;
final Map<String, String> environment;

@override
void initialize() {
_runGetter(const <String>['init']);
}

@override
List<RepositorySummary> listRepositories() {
final json = _runGetter(const <String>['repo', 'list']);
final repositories = _asList(_data(json)['repositories'], 'repositories');
return repositories.map(_repositoryFromJson).toList(growable: false);
}

@override
List<TrackedPackageSummary> listTrackedPackages() {
final json = _runGetter(const <String>['app', 'list']);
final apps = _asList(_data(json)['apps'], 'apps');
return apps.map(_trackedPackageFromJson).toList(growable: false);
}

@override
PackageEvaluation evaluatePackage(String packageId, {String? repositoryId}) {
final args = <String>['package', 'eval', packageId];
if (repositoryId != null) {
args.addAll(<String>['--repo', repositoryId]);
}
final json = _runGetter(args);
final package = _asMap(_data(json)['package'], 'package');
return _packageEvaluationFromJson(package);
}

@override
List<MigrationReportSummary> readMigrationReports() {
final json = _runGetter(const <String>['legacy', 'report-list']);
final reports = _asList(_data(json)['reports'], 'reports');
return reports
.map((report) => _migrationReportFromJson(_asMap(report, 'report')))
.toList(growable: false);
}

@override
GetterSnapshot loadSnapshot() {
initialize();
final repositories = listRepositories();
final trackedPackages = listTrackedPackages();
final apps = trackedPackages.map((tracked) {
final evaluated = evaluatePackage(
tracked.id,
repositoryId: tracked.repositoryId,
);
return AppSummary(
id: tracked.id,
name: evaluated.name,
installedVersion: 'unknown',
latestVersion: 'unknown',
hasFreeNetworkWarning: evaluated.hasFreeNetworkWarning,
);
}).toList(growable: false);

return GetterSnapshot(
status: 'Getter CLI ready',
updateCount: 0,
apps: apps,
repositories: repositories,
);
}

Map<String, Object?> _runGetter(List<String> commandArgs) {
final result = Process.runSync(
executable,
<String>['--data-dir', dataDir, ...commandArgs],
environment: environment.isEmpty ? null : environment,
);
final stdoutText = result.stdout.toString();
final decoded = stdoutText.trim().isEmpty
? <String, Object?>{}
: _asMap(jsonDecode(stdoutText), 'getter stdout');
if (result.exitCode != 0 || decoded['ok'] != true) {
final error = _errorFromEnvelope(decoded);
throw GetterBridgeException(error, exitCode: result.exitCode);
}
return decoded;
}
}

Map<String, Object?> _data(Map<String, Object?> envelope) {
return _asMap(envelope['data'], 'data');
}

GetterError _errorFromEnvelope(Map<String, Object?> envelope) {
final error = _asMap(envelope['error'], 'error');
return GetterError(
code: _asString(error['code'], 'error.code'),
message: _asString(error['message'], 'error.message'),
detail: error['detail'] as String?,
);
}

RepositorySummary _repositoryFromJson(Object? value) {
final json = _asMap(value, 'repository');
return RepositorySummary(
id: _asString(json['id'], 'repository.id'),
priority: _asInt(json['priority'], 'repository.priority'),
);
}

TrackedPackageSummary _trackedPackageFromJson(Object? value) {
final json = _asMap(value, 'tracked package');
return TrackedPackageSummary(
id: _asString(json['id'], 'tracked.id'),
enabled: _asBool(json['enabled'], 'tracked.enabled'),
favorite: _asBool(json['favorite'], 'tracked.favorite'),
ignoredVersion: json['ignored_version'] as String?,
repositoryId: json['repository_id'] as String?,
packageResolution: _asString(
json['package_resolution'],
'tracked.package_resolution',
),
);
}

PackageEvaluation _packageEvaluationFromJson(Object? value) {
final json = _asMap(value, 'package');
final permissions = _asMap(json['permissions'], 'package.permissions');
return PackageEvaluation(
id: _asString(json['id'], 'package.id'),
repositoryId: _asString(json['repository'], 'package.repository'),
name: _asString(json['name'], 'package.name'),
hasFreeNetworkWarning: _asBool(
permissions['free_network'],
'package.permissions.free_network',
),
);
}

MigrationReportSummary _migrationReportFromJson(Map<String, Object?> json) {
return MigrationReportSummary(
ok: _asBool(json['ok'], 'migration.ok'),
code: _asString(json['code'], 'migration.code'),
message: _asString(json['message'], 'migration.message'),
importedRecords: _asInt(json['imported_records'], 'migration.imported'),
trackedRecords: _asInt(json['tracked_records'], 'migration.tracked'),
);
}

Map<String, Object?> _asMap(Object? value, String name) {
if (value is Map<String, Object?>) {
return value;
}
if (value is Map) {
return value.cast<String, Object?>();
}
throw FormatException('$name should be a JSON object');
}

List<Object?> _asList(Object? value, String name) {
if (value is List<Object?>) {
return value;
}
if (value is List) {
return value.cast<Object?>();
}
throw FormatException('$name should be a JSON array');
}

String _asString(Object? value, String name) {
if (value is String) {
return value;
}
throw FormatException('$name should be a string');
}

int _asInt(Object? value, String name) {
if (value is int) {
return value;
}
throw FormatException('$name should be an integer');
}

bool _asBool(Object? value, String name) {
if (value is bool) {
return value;
}
throw FormatException('$name should be a boolean');
}
1 change: 1 addition & 0 deletions app_flutter/lib/fake_getter_adapter.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export 'getter_adapter.dart' show FakeGetterAdapter;
Loading