Skip to content
Open
Changes from 1 commit
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
6461120
docs: add rewrite architecture records
xz-dev Jun 22, 2026
9527287
chore: add rewrite agent guardrails
xz-dev Jun 22, 2026
ae0d72c
feat(app): add Flutter shell scaffold
xz-dev Jun 22, 2026
4756f7c
feat(getter): wire package-centric getter submodule
xz-dev Jun 22, 2026
a5730a9
ci: add rewrite validation workflow
xz-dev Jun 22, 2026
59c1a0d
fix(getter): keep Android proxy off Lua deps
xz-dev Jun 22, 2026
3201d92
fix(app): use Flutter-compatible Gradle wrapper
xz-dev Jun 22, 2026
35e6c3d
ci: restrict Telegram notifications to master pushes
xz-dev Jun 22, 2026
80e1eb6
fix(app): use Flutter-compatible AGP
xz-dev Jun 22, 2026
384aee6
docs: add rewrite next-step audit plan
xz-dev Jun 22, 2026
a1c43f4
fix(app): use Flutter-compatible Kotlin plugin
xz-dev Jun 22, 2026
c6838b5
docs: update rewrite next-step completion status
xz-dev Jun 22, 2026
76f771a
feat(app): add getter bridge contract
xz-dev Jun 22, 2026
47f5811
feat(getter): add offline repo validation
xz-dev Jun 22, 2026
0976844
feat(getter): import legacy Room databases
xz-dev Jun 22, 2026
81a5dec
feat(getter): add installed app autogen
xz-dev Jun 22, 2026
8f3ca13
feat(getter): add offline update check
xz-dev Jun 22, 2026
9bb18f2
feat(getter): add offline task lifecycle
xz-dev Jun 23, 2026
1ba7614
feat(app): render getter task DTOs
xz-dev Jun 23, 2026
aed83cb
ci(app): publish Flutter APK artifacts
xz-dev Jun 23, 2026
2e22767
feat(app): add legacy Room migration adapter
xz-dev Jun 23, 2026
39af4c7
feat(app): add Android platform adapter spine
xz-dev Jun 23, 2026
3a5a602
feat(app): add Android installed inventory provider
xz-dev Jun 23, 2026
dd94154
feat(app): bridge installed autogen to Flutter
xz-dev Jun 23, 2026
8a6ac21
feat(app): bridge legacy room import
xz-dev Jun 24, 2026
044ca72
ci: set Android ar for cargo checks
xz-dev Jun 24, 2026
65df6ab
test(app): cover legacy room preparation
xz-dev Jun 24, 2026
c0f6752
test(app): validate native bridge on device
xz-dev Jun 24, 2026
d392b5c
docs(architecture): accept runtime task ADRs
xz-dev Jun 25, 2026
dba34ec
feat(app): bridge runtime task operations
xz-dev Jun 25, 2026
108625a
feat(app): stream runtime notifications
xz-dev Jun 25, 2026
2b98939
docs(todo): update runtime bridge progress
xz-dev Jun 25, 2026
ced8576
feat(app): issue runtime actions from update checks
xz-dev Jun 25, 2026
5061d20
docs(todo): note offline action issuance
xz-dev Jun 25, 2026
71c71c9
docs(lua): document static update candidates
xz-dev Jun 25, 2026
75b9f65
feat(app): issue actions from registered packages
xz-dev Jun 25, 2026
2aad93f
docs(todo): note registered package action issuance
xz-dev Jun 25, 2026
7ebf9be
feat(app): adopt pin version DTOs
xz-dev Jun 25, 2026
c1f7126
feat(app): add typed runtime task APIs
xz-dev Jun 25, 2026
b2c03b7
chore(app): point CLI debug tasks at runtime script
xz-dev Jun 25, 2026
3897038
refactor(app): drop fake task DTOs from product adapter
xz-dev Jun 25, 2026
dd9115c
docs(lua): describe static mock provider boundary
xz-dev Jun 25, 2026
1530a42
refactor(app): drop CLI fake task adapter APIs
xz-dev Jun 25, 2026
7bcaa0b
ci: install multilib for Android LuaJIT builds
xz-dev Jun 25, 2026
4e6274a
chore(app): update Flutter toolchain baseline
xz-dev Jun 25, 2026
25af79c
feat(app): load snapshots from native getter read model
xz-dev Jun 25, 2026
1a5d822
feat(app): submit update checks to runtime
xz-dev Jun 25, 2026
239f98f
docs(architecture): define provider autogen repository model
xz-dev Jun 26, 2026
4d65323
feat(app): use ADR-0012 autogen repository defaults
xz-dev Jun 26, 2026
03cb206
feat(getter): use package directory discovery
xz-dev Jun 26, 2026
4dea731
feat(app): consume package-directory autogen previews
xz-dev Jun 26, 2026
346636f
feat(getter): evaluate package directories
xz-dev Jun 26, 2026
aa3fdbb
fix(getter): update clippy-clean gitlink
xz-dev Jun 26, 2026
a8739cc
feat(getter): expose package-local file reads
xz-dev Jun 26, 2026
1ce7701
fix(getter): hash package-local file inputs
xz-dev Jun 26, 2026
175ae4c
feat(getter): add provider cache primitives
xz-dev Jun 26, 2026
e0673f2
feat(getter): add F-Droid provider fixtures
xz-dev Jun 26, 2026
1a13cbd
feat(getter): cache F-Droid catalog fixtures
xz-dev Jun 26, 2026
728cff6
feat(getter): add F-Droid autogen CLI slice
xz-dev Jun 27, 2026
dddce32
feat(getter): match F-Droid installed inventory
xz-dev Jun 27, 2026
b35b7c4
feat(getter): add GitHub release fixtures
xz-dev Jun 27, 2026
416075e
refactor(getter): remove flat Lua repository layout
xz-dev Jun 27, 2026
80df257
feat(app): expose F-Droid autogen bridge
xz-dev Jun 27, 2026
eb1719d
feat(getter): add GitHub latest commit fixtures
xz-dev Jun 27, 2026
be6f4b3
test(getter): cover F-Droid luaclass shape
xz-dev Jun 27, 2026
526e5d4
test(getter): cover GitHub luaclass shape
xz-dev Jun 27, 2026
cb74bba
feat(getter): add Lua host binding seam
xz-dev Jun 27, 2026
2f6585e
feat(getter): add dev Lua provider host eval
xz-dev Jun 27, 2026
345ef45
feat(getter): add F-Droid dev Lua provider host eval
xz-dev Jun 27, 2026
4e06159
feat(getter): add builtin luaclass fallback
xz-dev Jun 27, 2026
b8e929a
feat(getter): add Lua HTTP host seam
xz-dev Jun 27, 2026
64e2fb4
feat(getter): add dev provider luaclass modules
xz-dev Jun 27, 2026
dd1c259
feat(getter): add Lua HTTP policy harness
xz-dev Jun 27, 2026
8942c7f
feat(getter): add runtime hook harness
xz-dev Jun 27, 2026
19f2fd9
docs(architecture): design provider host API v1
xz-dev Jun 28, 2026
016f977
feat(getter): add stable provider host harness
xz-dev Jun 28, 2026
561d0e7
feat(getter): store provider response provenance
xz-dev Jun 28, 2026
b20fb0a
feat(getter): promote standard provider luaclasses
xz-dev Jun 28, 2026
c86c894
fix(getter): validate provider endpoint ids
xz-dev Jun 28, 2026
9e2be1e
test(getter): lock fdroid generated script boundary
xz-dev Jun 28, 2026
3b70b92
docs(plan): defer fdroid generated provider adoption
xz-dev Jun 28, 2026
0bb0c77
test(getter): cover configured provider endpoints
xz-dev Jun 28, 2026
236794e
feat(getter): use provider-backed update checks
xz-dev Jun 28, 2026
e1993f2
feat(getter): use F-Droid provider module autogen output
xz-dev Jun 28, 2026
67e99a8
feat(app): add installed F-Droid autogen flow
xz-dev Jun 29, 2026
1f7773b
feat(app): refresh F-Droid catalog cache
xz-dev Jun 29, 2026
4fbb6ca
feat(getter): add GitHub standard module runtime slice
xz-dev Jul 2, 2026
a1cdee6
feat(getter): add GitHub autogen product seam
xz-dev Jul 2, 2026
31ab0f9
feat(getter): add GitHub releases live transport slice
xz-dev Jul 2, 2026
5a380f6
feat(app): add GitHub autogen product bridge
xz-dev Jul 2, 2026
1b49340
feat(app): run getter-owned download bytes
xz-dev Jul 2, 2026
ea26f3e
feat(app): load getter startup snapshot
xz-dev Jul 14, 2026
c1f79c1
docs(cli): document app inspect and check
xz-dev Jul 14, 2026
171fb8e
docs(architecture): define artifact staging and installers
xz-dev Jul 16, 2026
0cd8a4b
feat(app): guide fresh package setup
xz-dev Jul 17, 2026
2369bcc
feat(app): bridge Android APK install preparation
xz-dev Jul 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: update rewrite next-step completion status
Record the completed Kotlin CI fix, green PR checks, submodule verification, and updated PR descriptions in the rewrite todo plan.
  • Loading branch information
xz-dev committed Jun 22, 2026
commit c6838b50c27026f9654d2f21a5e9bbb5520dc62b
218 changes: 72 additions & 146 deletions todo.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# UpgradeAll rewrite next-step audit and plan

Date: 2026-06-22 14:36 CST
Completion update: 2026-06-22 15:15 CST
Repo: `DUpdateSystem/UpgradeAll`
Branch checked: `rewrite/flutter-getter-spine`
Superproject HEAD checked before this document: `80e1eb60 fix(app): use Flutter-compatible AGP`
Superproject HEAD after completing the immediate CI fix: `a1c43f43 fix(app): use Flutter-compatible Kotlin plugin`
Getter submodule checked: `core-getter/src/main/rust/getter` -> `3b7613d709b405cb7229f2fbbf546c2d29ee96e6`

This document is the canonical next-step plan after reviewing:
Expand All @@ -24,6 +26,13 @@ This document is the canonical next-step plan after reviewing:

There is no major architecture drift from the original rewrite plan.

Completion update: the immediate CI blocker described in this document has been fixed. The Kotlin Gradle Plugin was upgraded to `2.0.0`, the fix was pushed in `a1c43f43`, and both UpgradeAll PR checks are now green:

```text
Android CI / Build: success
UpgradeAll Rewrite Validation / Rewrite validation: success
```

The completed work is broadly aligned with the intended direction:

```text
Expand All @@ -37,24 +46,24 @@ SQLite main.db + cache.db
-> durable state split from rebuildable cache
```

The important caveat is that the branch is not merge-ready yet because UpgradeAll rewrite validation CI is red. The immediate blocker is Flutter/Kotlin Gradle Plugin compatibility, not a design issue.

The second caveat is process discipline: the Flutter shell has been created, but it must stay a shell until the real getter bridge is designed and wired. Do not add more product UI behavior that duplicates getter logic.
The earlier caveat that the branch was not merge-ready because rewrite validation CI was red is now resolved. The remaining caveat is process discipline: the Flutter shell has been created, but it must stay a shell until the real getter bridge is designed and wired. Do not add more product UI behavior that duplicates getter logic.

## 2. Current state evidence

### Superproject

```text
branch: rewrite/flutter-getter-spine
HEAD: 80e1eb60bed05eaac7875c477d377ed046111f19
HEAD after completing the immediate CI fix: a1c43f43505924ce55095d8f342d699d4d470a2a
PR: https://github.com/DUpdateSystem/UpgradeAll/pull/514
status before this todo.md: only untracked todo-next-step.md
status after cleanup should be clean except this document update until committed
```

Recent superproject commits:

```text
a1c43f43 fix(app): use Flutter-compatible Kotlin plugin
384aee6c docs: add rewrite next-step audit plan
80e1eb60 fix(app): use Flutter-compatible AGP
35e6c3d1 ci: restrict Telegram notifications to master pushes
3201d92d fix(app): use Flutter-compatible Gradle wrapper
Expand Down Expand Up @@ -93,19 +102,26 @@ clippy-sarif: skipped as expected

### UpgradeAll CI state

At review time:
At review time the state was:

```text
Android CI: success
UpgradeAll Rewrite Validation: failure
```

Latest failure in rewrite validation:
The failure in rewrite validation was:

```text
Error: Your project's Kotlin version (1.9.22) is lower than Flutter's minimum supported version of 2.0.0. Please upgrade your Kotlin version.
```

Completion update: the Kotlin compatibility fix was committed and pushed, and the current PR checks are now:

```text
Android CI / Build: success
UpgradeAll Rewrite Validation / Rewrite validation: success
```

Relevant files:

```text
Expand All @@ -114,11 +130,11 @@ app_flutter/android/settings.gradle
app_flutter/android/app/build.gradle
```

Current Kotlin source:
Current Kotlin source after the fix:

```groovy
// app_flutter/android/build.gradle
ext.kotlin_version = '1.9.22'
ext.kotlin_version = '2.0.0'
```

Also observed from the failed CI log:
Expand All @@ -144,22 +160,19 @@ Do not jump to AGP 9 as part of the immediate fix unless the minimal Kotlin fix
| ExtraApp preservation | Do not repeat old bug of skipping `extra_app` state | Current mapping preserves `ignored_version` and `favorite` from extra app slice | Aligned for current slice |
| Flutter UI | Flutter owns UI/platform only | `FakeGetterAdapter`, route keys, placeholder pages; no real product logic | Acceptable shell; freeze scope until bridge |
| Mixed TDD/BDD | TDD for Rust/domain, BDD for user-facing/integration | Rust unit tests + CLI BDD + Flutter widget tests | Aligned |
| Verification | `just verify` should be the main gate | `just verify` exists and is used by workflow | Aligned, but currently red in CI |
| Verification | `just verify` should be the main gate | `just verify` exists, passes locally, and passes in the rewrite validation workflow | Aligned |

## 4. Deviations / risks to control

### 4.1 CI is red due Kotlin Gradle Plugin

This is the immediate blocker. Do not continue feature work before making rewrite validation green.
### 4.1 Resolved Kotlin Gradle Plugin CI blocker

Current issue:
The immediate CI blocker has been resolved. The fix was intentionally minimal:

```text
app_flutter/android/build.gradle: ext.kotlin_version = '1.9.22'
Flutter stable in CI requires Kotlin >= 2.0.0
app_flutter/android/build.gradle: ext.kotlin_version = '2.0.0'
```

This is not an architecture deviation. It is a build compatibility issue.
This clears Flutter stable's Kotlin >= 2.0.0 dependency validation without changing architecture or feature scope.

### 4.2 Flutter shell exists before real bridge

Expand Down Expand Up @@ -206,179 +219,92 @@ Still missing:

This is acceptable now, but must be called out in PR notes.

### 4.5 Plain non-interactive SSH shell did not expose Flutter

From this review shell, `flutter` was not found when running a simple SSH command. CI installs Flutter and previous local validation may have used a different shell/toolchain environment.

Before claiming local validation on genx, the next agent must either:

1. run from the environment where Flutter is actually on PATH, or
2. locate/source the Flutter installation explicitly, or
3. rely on GitHub Actions and report that local Flutter was unavailable.

Do not claim `just verify` passed locally unless the command actually ran in the current environment.

## 5. Immediate next plan: make rewrite validation CI green

This must be the next implementation task.

### Objective

Make `UpgradeAll Rewrite Validation` pass for PR #514 without changing architecture or adding feature scope.
### 4.5 Validation environment note

### Files likely touched
The Kotlin fix was validated in the active agent environment with:

```text
app_flutter/android/build.gradle
app_flutter/android/settings.gradle
app_flutter/android/app/build.gradle
cd app_flutter && flutter build apk --debug
just verify
./gradlew --no-daemon ':core-getter:buildDebugApi_proxyRust[armeabi-v7a]'
```

### Step 1: try the minimal Kotlin fix first
CI also validated the branch with Java 21 and the current Flutter stable action. Future agents should still report the actual local toolchain used when claiming local validation, because Flutter stable's minimum Gradle/AGP/Kotlin checks can move over time.

## 5. Completed immediate plan: make rewrite validation CI green

Status: completed in `a1c43f43 fix(app): use Flutter-compatible Kotlin plugin`.

Edit:
What changed:

```diff
// app_flutter/android/build.gradle
- ext.kotlin_version = '1.9.22'
+ ext.kotlin_version = '2.0.0'
```

Do not change AGP or Gradle wrapper in the same commit unless the Kotlin-only fix fails. Keeping the diff small makes the failure mode obvious.
Why this was enough:

### Step 2: run focused local checks
- The latest failing Rewrite Validation log reported only Flutter's Kotlin Gradle Plugin minimum-version gate.
- The existing Flutter Android template remained coherent with the minimal `buildscript` Kotlin classpath bump.
- No architecture, feature, AGP, or Gradle wrapper scope was expanded in this fix.

Preferred local commands:
Validation completed after the fix:

```bash
cd ~/Code/DUpdateSystem/UpgradeAll
cd app_flutter
flutter build apk --debug
cd ..
```text
cd app_flutter && flutter build apk --debug
just verify
./gradlew --no-daemon ':core-getter:buildDebugApi_proxyRust[armeabi-v7a]'
```

If `flutter` is not on PATH in the current SSH shell, first locate or source the Flutter environment. If that is not practical, push the minimal change and use GitHub Actions as the verification source, but report that local Flutter was unavailable.

Do not commit a workaround that uses:
GitHub Actions on PR #514 after the fix:

```text
--android-skip-build-dependency-validation
Android CI / Build: success
UpgradeAll Rewrite Validation / Rewrite validation: success
```

That flag is diagnostic only, not the real fix.

### Step 3: if minimal fix fails, modernize Kotlin plugin declaration
No committed workaround uses `--android-skip-build-dependency-validation`.

If Flutter/Gradle still complains after `ext.kotlin_version = '2.0.0'`, switch to the modern plugin DSL.

Likely shape:

```groovy
// app_flutter/android/settings.gradle
plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.6.0" apply false
id "org.jetbrains.kotlin.android" version "2.0.0" apply false
}
```
## 6. Completed PR stabilization checklist

Then update:

```diff
// app_flutter/android/app/build.gradle
plugins {
id "com.android.application"
- id "kotlin-android"
+ id "org.jetbrains.kotlin.android"
id "dev.flutter.flutter-gradle-plugin"
}
```

If this works, remove obsolete top-level `buildscript` Kotlin classpath only after verifying the Flutter template still builds.

### Step 4: commit and push the CI fix

```bash
git status --short --branch --untracked-files=all
git add app_flutter/android/build.gradle app_flutter/android/settings.gradle app_flutter/android/app/build.gradle
git commit --no-gpg-sign -m "fix(app): use Flutter-compatible Kotlin plugin"
git push
```

### Step 5: watch CI

```bash
gh run list --repo DUpdateSystem/UpgradeAll --branch rewrite/flutter-getter-spine --limit 10
gh pr checks 514 --repo DUpdateSystem/UpgradeAll
```

If PR checks still do not attach automatically, manually dispatch both branch workflows:

```bash
gh workflow run upgradeall-rewrite-validation.yml --repo DUpdateSystem/UpgradeAll --ref rewrite/flutter-getter-spine
gh workflow run android.yml --repo DUpdateSystem/UpgradeAll --ref rewrite/flutter-getter-spine
```

Acceptance:
### 6.1 Submodule integrity confirmed

```text
Android CI: success
UpgradeAll Rewrite Validation: success
Getter PR #54 checks: still green
```

## 6. After CI is green: PR stabilization checklist

Do this before any new feature work.

### 6.1 Confirm submodule integrity

```bash
git ls-files -s core-getter/src/main/rust/getter
git submodule status core-getter/src/main/rust/getter
160000 3b7613d709b405cb7229f2fbbf546c2d29ee96e6 0 core-getter/src/main/rust/getter
3b7613d709b405cb7229f2fbbf546c2d29ee96e6 core-getter/src/main/rust/getter (heads/rewrite/package-cli-spine)
```

Expected:
The getter remains a real `160000` gitlink and is not vendored into the UpgradeAll superproject.

```text
core-getter/src/main/rust/getter remains mode 160000
submodule points to getter branch commit 3b7613d or later pushed getter commit
```
### 6.2 Local scratch notes cleaned

### 6.2 Clean or consciously leave local notes

Current local note:
Temporary local scratch/review artifacts were removed after their useful content was folded into this tracked `todo.md`:

```text
?? todo-next-step.md
todo-next-step.md
subagent-artifacts/review-kotlin-todo.md
```

Decide explicitly:

- keep it untracked as scratch, or
- delete it, or
- replace it with this committed `todo.md`.

Do not accidentally include machine-local scratch files in feature commits.

### 6.3 Update PR descriptions
### 6.3 PR descriptions updated

UpgradeAll PR #514 should say clearly:
UpgradeAll PR #514 now states:

- this is a rewrite spine, not a product-complete release
- docs/ADR/AGENTS were added
- getter is a submodule and points to getter PR #54
- getter is a submodule and points to getter PR #54 / `3b7613d709b405cb7229f2fbbf546c2d29ee96e6`
- Flutter shell is intentionally fake-adapter only
- current validation commands
- known deferred work: real bridge, direct Room migration, local_autogen, provider/downloader/update lifecycle
- Gradle/AGP/Kotlin compatibility fixes are included
- current CI validation is green
- deferred work includes real bridge, direct Room migration, `local_autogen`, provider/downloader/update lifecycle

Getter PR #54 should say clearly:
Getter PR #54 now states:

- package-centric CLI/core rewrite
- old hub-app model is not coming back
- old hub-app model is not restored
- old provider/downloader/RPC behavior is deferred, not silently retained
- CI is green except skipped optional SARIF
- Android JNI/API proxy consumers can depend on getter without pulling Lua/domain dependencies
- checks are green except optional SARIF skip

## 7. Next architecture gate: real Flutter-to-getter bridge

Expand Down