fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

puretension · 2025-09-18T17:15:27Z

What does this PR do?

Fixes AttributeError when Proxmox VMs don't have Qemu Agent installed or available.

Motivation

Fixes #21300 - When Qemu Agent is not installed on Proxmox VMs, the /agent/get-host-name endpoint fails and causes an AttributeError. This breaks hostname collection for VMs without the agent.

Description of the changes

Add AttributeError to the existing exception handling in _get_vm_hostname()
Falls back to using vm_name when Qemu Agent is unavailable
Maintains existing logging behavior for debugging

How to test the changes?

Test with Proxmox VMs that don't have Qemu Agent installed - the integration should continue working and use VM names as hostnames.

Review checklist

Feature or bugfix MUST have appropriate tests (existing tests cover the fallback behavior)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA
If you need to backport this PR to another branch, you can add the backport/ label

codecov · 2025-09-18T17:19:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.00%. Comparing base (d0a9b95) to head (2e34aa3).
⚠️ Report is 68 commits behind head on master.

Additional details and impacted files

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-09-18T17:33:58Z

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and
the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent

proxmox/changelog.d/21399.fixed
proxmox/datadog_checks/proxmox/check.py

sarah-witt

This looks great, thanks for the fix!

proxmox/datadog_checks/proxmox/check.py

Review from sarah-witt is dismissed. Related teams and files:

agent-integrations
- proxmox/datadog_checks/proxmox/check.py
- proxmox/tests/test_unit.py

Fixes DataDog#21300 Signed-off-by: puretension <[email protected]>

Signed-off-by: puretension <[email protected]>

- Add AttributeError to existing exception handling in _get_vm_hostname() - Fall back to using vm_name when Qemu Agent is unavailable - Add test case for AttributeError scenario - Maintain existing logging behavior for debugging Fixes DataDog#21300 Signed-off-by: puretension <[email protected]>

proxmox/datadog_checks/proxmox/check.py

- Move hostname parsing logic inside try block for cleaner error handling - Maintain fallback to vm_name when API call fails - Improve code readability and exception flow Co-authored-by: sarah-witt <[email protected]> Signed-off-by: puretension <[email protected]> Signed-off-by: sarah-witt <[email protected]>

proxmox/tests/test_unit.py

…zed test Move test_get_hostname_attribute_error test case to a parameter in test_get_hostname_error and use MockResponse class as requested in review. Signed-off-by: puretension <[email protected]>

…not configured - Replace AttributeErrorMockResponse with MockResponse using status_code=200 - Use actual JSON response: {"data": null, "message": "No QEMU guest agent configured\n"} - Update test case ID to qemu_agent_not_configured for clarity Signed-off-by: puretension <[email protected]>

Remove multiple consecutive blank lines that were causing linting failures Signed-off-by: puretension <[email protected]>

- Add required blank lines between functions - Fix trailing comma spacing in MockResponse Signed-off-by: puretension <[email protected]>

sarah-witt

Looks good, thanks!

puretension · 2025-10-20T15:05:51Z

Thanks a lot, @sarah-witt! 🙏
Really appreciate your proactive feedback and guidance. it helped me get this fix merged smoothly.
It’s an honor to have my first Datadog contribution merged!
I’ll keep contributing more actively to Datadog.

aadlung · 2025-11-16T10:10:38Z

When will this be included into the actual Datadog agent? When I updated it e.g. to 7.72.2 it is still the old check.py in the Proxmox integration?

Kyle-Neale · 2025-11-17T00:59:02Z

When will this be included into the actual Datadog agent? When I updated it e.g. to 7.72.2 it is still the old check.py in the Proxmox integration?

This should be included in v7.73.0 of the Agent which includes v2.2.0 of the Proxmox integration.

Handle AttributeError when Qemu Agent is not available (fix(proxmox): handle AttributeError when Qemu Agent is not available #21399)

puretension requested a review from a team as a code owner September 18, 2025 17:15

temporal-github-worker-1 bot added agent/review-requested ecosystems/review-requested product/review-requested labels Sep 18, 2025

datadog-agent-integrations-bot bot added integration/proxmox team/agent-integrations labels Sep 18, 2025

temporal-github-worker-1 bot added the docs/review-requested label Sep 18, 2025

datadog-agent-integrations-bot bot added documentation qa/skip-qa Automatically skip this PR for the next QA release labels Sep 18, 2025

temporal-github-worker-1 bot removed the docs/review-requested label Sep 18, 2025

puretension force-pushed the fix-proxmox-hostname-without-qemu-agent-21300 branch from 19ffa61 to 5d4b286 Compare September 18, 2025 18:03

sarah-witt previously approved these changes Sep 29, 2025

View reviewed changes

temporal-github-worker-1 bot added agent/approved and removed agent/review-requested labels Sep 29, 2025

sarah-witt requested changes Sep 29, 2025

View reviewed changes

proxmox/datadog_checks/proxmox/check.py Outdated Show resolved Hide resolved

temporal-github-worker-1 bot added agent/requested-changes and removed agent/approved labels Sep 29, 2025

puretension added 6 commits September 30, 2025 11:14

proxmox: handle AttributeError when Qemu Agent is not available

276ef48

Fixes DataDog#21300 Signed-off-by: puretension <[email protected]>

Add changelog entry for proxmox AttributeError fix

944c1bf

bump proxmox version to 2.0.1

2a50ed5

add changelog entry and update requirements for proxmox 2.0.1

6440b1b

fix changelog validation - remove duplicate entry

e794d99

revert version to 2.0.0 - let release process handle version bump

b065a49

Signed-off-by: puretension <[email protected]>

puretension force-pushed the fix-proxmox-hostname-without-qemu-agent-21300 branch from 8afb64b to 8f59804 Compare September 30, 2025 02:15

puretension force-pushed the fix-proxmox-hostname-without-qemu-agent-21300 branch from 24be028 to e4715eb Compare September 30, 2025 05:58

sarah-witt reviewed Oct 8, 2025

View reviewed changes

proxmox/datadog_checks/proxmox/check.py Outdated Show resolved Hide resolved

puretension and others added 2 commits October 9, 2025 02:56

Merge branch 'master' into fix-proxmox-hostname-without-qemu-agent-21300

4ac6724

sarah-witt reviewed Oct 8, 2025

View reviewed changes

proxmox/tests/test_unit.py Outdated Show resolved Hide resolved

puretension added 4 commits October 11, 2025 21:10

fix(proxmox): consolidate hostname error tests into single parameteri…

0f50d21

…zed test Move test_get_hostname_attribute_error test case to a parameter in test_get_hostname_error and use MockResponse class as requested in review. Signed-off-by: puretension <[email protected]>

Fix linting errors in proxmox test_unit.py

301f505

Remove multiple consecutive blank lines that were causing linting failures Signed-off-by: puretension <[email protected]>

fix: resolve linting errors in proxmox test_unit.py

2e34aa3

- Add required blank lines between functions - Fix trailing comma spacing in MockResponse Signed-off-by: puretension <[email protected]>

sarah-witt approved these changes Oct 20, 2025

View reviewed changes

temporal-github-worker-1 bot added agent/approved and removed agent/requested-changes labels Oct 20, 2025

sarah-witt added this pull request to the merge queue Oct 20, 2025

Merged via the queue into DataDog:master with commit f40b1e3 Oct 20, 2025
32 of 33 checks passed

skorn-atom mentioned this pull request Nov 5, 2025

Bump Datadog Ansible collection ansible-collections/Datadog#150

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

Uh oh!

puretension commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

sarah-witt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarah-witt left a comment

Uh oh!

Uh oh!

puretension commented Oct 20, 2025 •

edited

Loading

Uh oh!

aadlung commented Nov 16, 2025

Uh oh!

Kyle-Neale commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

Uh oh!

Conversation

puretension commented Sep 18, 2025

What does this PR do?

Motivation

Description of the changes

How to test the changes?

Review checklist

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarah-witt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarah-witt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

puretension commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aadlung commented Nov 16, 2025

Uh oh!

Kyle-Neale commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 18, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading

puretension commented Oct 20, 2025 •

edited

Loading