Skip to content

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarah-witt merged 13 commits into from
Oct 20, 2025
Merged

fix(proxmox): handle AttributeError when Qemu Agent is not available #21399

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
276ef48
proxmox: handle AttributeError when Qemu Agent is not available
puretension Sep 18, 2025
944c1bf
Add changelog entry for proxmox AttributeError fix
puretension Sep 18, 2025
2a50ed5
bump proxmox version to 2.0.1
puretension Sep 18, 2025
6440b1b
add changelog entry and update requirements for proxmox 2.0.1
puretension Sep 18, 2025
e794d99
fix changelog validation - remove duplicate entry
puretension Sep 18, 2025
b065a49
revert version to 2.0.0 - let release process handle version bump
puretension Sep 18, 2025
e4715eb
fix(proxmox): handle AttributeError when Qemu Agent is not available
puretension Sep 30, 2025
b9c0041
fix(proxmox): move hostname extraction logic before exception handling
puretension Oct 8, 2025
4ac6724
Merge branch 'master' into fix-proxmox-hostname-without-qemu-agent-21300
puretension Oct 8, 2025
0f50d21
fix(proxmox): consolidate hostname error tests into single parameteri…
puretension Oct 11, 2025
bfe184d
fix(proxmox): update test to use actual JSON response for Qemu Agent …
puretension Oct 15, 2025
301f505
Fix linting errors in proxmox test_unit.py
puretension Oct 16, 2025
2e34aa3
fix: resolve linting errors in proxmox test_unit.py
puretension Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linting errors in proxmox test_unit.py 
Remove multiple consecutive blank lines that were causing linting failures

Signed-off-by: puretension <[email protected]>
  • Loading branch information
@puretension
puretension committed Oct 16, 2025
commit 301f505a8fba824b8ae0217772040a2ae5e39dc1
35 changes: 0 additions & 35 deletions proxmox/tests/test_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
STORAGE_RESOURCE_METRICS,
VM_PERF_METRICS,
)


@pytest.mark.usefixtures('mock_http_get')
def test_api_up(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand All @@ -41,8 +39,6 @@ def test_api_up(dd_run_check, aggregator, instance):

aggregator.assert_all_metrics_covered()
aggregator.assert_metrics_using_metadata(get_metadata_metrics())


@pytest.mark.usefixtures('mock_http_get')
def test_no_tags(dd_run_check, aggregator, instance):
new_instance = copy.deepcopy(instance)
Expand All @@ -52,8 +48,6 @@ def test_no_tags(dd_run_check, aggregator, instance):
aggregator.assert_metric(
"proxmox.api.up", 1, tags=['proxmox_server:http://localhost:8006/api2/json', 'proxmox_status:up']
)


@pytest.mark.parametrize(
('mock_http_get'),
[
Expand All @@ -77,8 +71,6 @@ def test_api_down(dd_run_check, aggregator, instance):
aggregator.assert_metric(
"proxmox.api.up", 0, tags=['proxmox_server:http://localhost:8006/api2/json', 'proxmox_status:down', 'testing']
)


@pytest.mark.usefixtures('mock_http_get')
def test_version_metadata(dd_run_check, datadog_agent, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand All @@ -93,8 +85,6 @@ def test_version_metadata(dd_run_check, datadog_agent, aggregator, instance):
'version.raw': '8.4.1',
}
datadog_agent.assert_metadata('test:123', version_metadata)


@pytest.mark.usefixtures('mock_http_get')
def test_resource_count_metrics(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand Down Expand Up @@ -195,8 +185,6 @@ def test_resource_count_metrics(dd_run_check, aggregator, instance):
],
hostname='',
)


@pytest.mark.usefixtures('mock_http_get')
def test_resource_up_metrics(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand Down Expand Up @@ -262,9 +250,6 @@ def test_resource_up_metrics(dd_run_check, aggregator, instance):
],
hostname='',
)



@pytest.mark.parametrize(
('mock_http_get'),
[
Expand Down Expand Up @@ -310,8 +295,6 @@ def test_get_hostname_error(dd_run_check, aggregator, instance, caplog):
"Failed to get hostname for vm 100 on node ip-122-82-3-112; endpoint: http://localhost:8006/api2/json;"
in caplog.text
)


@pytest.mark.usefixtures('mock_http_get')
def test_external_tags(dd_run_check, aggregator, instance, datadog_agent):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand Down Expand Up @@ -345,8 +328,6 @@ def test_external_tags(dd_run_check, aggregator, instance, datadog_agent):
]
},
)


@pytest.mark.usefixtures('mock_http_get')
def test_resource_metrics(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand Down Expand Up @@ -414,8 +395,6 @@ def test_resource_metrics(dd_run_check, aggregator, instance):
for metric in RESOURCE_METRICS:
aggregator.assert_metric(metric, count=0, tags=sdn_tags)
aggregator.assert_metric(metric, count=0, tags=pool_tags)


@pytest.mark.usefixtures('mock_http_get')
def test_perf_metrics(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
Expand Down Expand Up @@ -485,24 +464,18 @@ def test_perf_metrics(dd_run_check, aggregator, instance):
for metric in PERF_METRICS:
aggregator.assert_metric(metric, count=0, tags=sdn_tags)
aggregator.assert_metric(metric, count=0, tags=pool_tags)


@pytest.mark.usefixtures('mock_http_get')
def test_perf_metrics_error(dd_run_check, caplog, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
caplog.set_level(logging.DEBUG)
dd_run_check(check)
assert "Invalid metric entry found; metric name: disk.used, resource id: storage/ip-122-82-3-112" in caplog.text


@pytest.mark.usefixtures('mock_http_get')
def test_ha_metrics(dd_run_check, aggregator, instance):
check = ProxmoxCheck('proxmox', {}, [instance])
dd_run_check(check)
aggregator.assert_metric('proxmox.ha.quorum', hostname='ip-122-82-3-112', tags=['node_status:OK'])
aggregator.assert_metric('proxmox.ha.quorate', hostname='ip-122-82-3-112', tags=['node_status:OK'])


@pytest.mark.parametrize(
('collect_tasks, task_types, expected_events'),
[
Expand Down Expand Up @@ -553,8 +526,6 @@ def test_events(get_current_datetime, dd_run_check, aggregator, instance, collec
aggregator.assert_event(**event)

assert len(aggregator.events) == len(expected_events)


@pytest.mark.parametrize(
('resource_filters, expected_vms, expected_nodes'),
[
Expand Down Expand Up @@ -751,8 +722,6 @@ def test_host_resource_filters(

num_xpected_hosts = len(expected_vms) + len(expected_nodes)
datadog_agent.assert_external_tags_count(num_xpected_hosts)


@pytest.mark.parametrize(
('resource_filters, expected_containers, expected_storages, expected_pools, expected_sdns'),
[
Expand Down Expand Up @@ -880,8 +849,6 @@ def test_additional_resource_filters(
aggregator.assert_metric("proxmox.storage.count", count=len(expected_storages))
aggregator.assert_metric("proxmox.pool.count", count=len(expected_pools))
aggregator.assert_metric("proxmox.sdn.count", count=len(expected_sdns))


@pytest.mark.parametrize(
('resource_filters, expected_message'),
[
Expand Down Expand Up @@ -974,8 +941,6 @@ def test_resource_filters_errors(dd_run_check, resource_filters, expected_messag
check = ProxmoxCheck('proxmox', {}, [instance])
dd_run_check(check)
assert expected_message in caplog.text


@pytest.mark.parametrize(
('resource_filters, expected_events'),
[
Expand Down
Loading