Skip to content

Handle new changes to site 2025-12#128

Merged
Deer-Spangle merged 15 commits intomasterfrom
handle-new-account-disabled-message
Dec 12, 2025
Merged

Handle new changes to site 2025-12#128
Deer-Spangle merged 15 commits intomasterfrom
handle-new-account-disabled-message

Conversation

@Deer-Spangle
Copy link
Copy Markdown
Owner

@Deer-Spangle Deer-Spangle commented Dec 11, 2025

There's been a few changes to the site lately, as the devs have been busy! And so, we have a list of tweaks needed here:

  • It seems there's a new account disabled message, so, let's handle that properly
  • [Tests only] Ensure new format datetimes are accepted in tests, luckily they are already parsed correctly in the parser itself
  • Handle "user not found" pages now returning a 400 HTTP status rather than 200
  • [Tests only] Update tests to match gender being a tag rather than a specific field now
  • Work around the bug where the first page of watchers/watchees returns a database error when page is actually set to 1 rather than left blank
  • [Tests only] Skip the test that journals parse correctly when a footer is set without a header being set, as FA currently has a bug where it won't show journal footers in this situation
  • Search page on FA uses GET params rather than POST data, and removes a couple of the silliest unused parameters
  • FA Search page numbers are no longer zero indexed, but 1 indexed
  • [Tests only] If comparing multiple FA search results, make sure each is valid before fetching the next, to avoid unnecessary search requests to FA during testing
  • [Tests only] FA Search can now return FASlowdownError, rather than just FAStatusError, handle that in tests

These should still be handled by `to_iso8601()` inside the actual application, that uses `Time.parse()` and is a bit more flexible. Maybe the test is too strict tbh, but hey
…or backwards compatibility, let's just subtract one when making the request. (I know, it seems a little horrible, but this application is full of horrible things done for backwards compatibility)
…dexed. For backwards compatibility, let's just subtract one when making the request. (I know, it seems a little horrible, but this application is full of horrible things done for backwards compatibility)"

This reverts commit 58c9e96.

Turns out they're not 0-indexed now. There's just some weirdness with empty watcher lists
…hat page 1 displays the same as the default page if there are no watchers
…ader" test as skipped, as this is a known and reported FA bug
@Deer-Spangle Deer-Spangle changed the title Handle the new account disabled message Handle new changes to site 2025-12 Dec 11, 2025
@Deer-Spangle Deer-Spangle merged commit 516b203 into master Dec 12, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant