Skip to content

Handle new changes to site 2025-12 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deer-Spangle merged 15 commits into from
Dec 12, 2025
Merged

Handle new changes to site 2025-12 #128

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
75e32d3
Handle the new account disabled message
Deer-Spangle Dec 11, 2025
404ed6c
Handle the new format datetimes as well.
Deer-Spangle Dec 11, 2025
256e562
Handle "user not found" error pages returning 400 status codes now, r…
Deer-Spangle Dec 11, 2025
9ef1196
Gender is always blank on submissions now, because they changed it to…
Deer-Spangle Dec 11, 2025
57a6432
Existing gender tags were moved to keywords, meaning the example subm…
Deer-Spangle Dec 11, 2025
58c9e96
Watcher list page numbers were changed from 1-indexed to 0-indexed. F…
Deer-Spangle Dec 11, 2025
d36b9e9
Second case of keywords including the gender tag now
Deer-Spangle Dec 11, 2025
0b9d51f
Revert "Watcher list page numbers were changed from 1-indexed to 0-in…
Deer-Spangle Dec 11, 2025
aedad81
Turns out watchers list isn't zero indexed, but now you can't trust t…
Deer-Spangle Dec 11, 2025
889c88e
Mark the "when viewing a journal post handles non existent journal he…
Deer-Spangle Dec 11, 2025
904174d
I think the search page uses GET params rather than POST params now?
Deer-Spangle Dec 11, 2025
b6920c3
If ever comparing multiple search results, ensure that at least 20 re…
Deer-Spangle Dec 12, 2025
940f14d
Search page numbers are no longer 0 indexed, and no longer need weird…
Deer-Spangle Dec 12, 2025
a7b87da
search_with_retry should also handle FASlowdownError, not just FAStat…
Deer-Spangle Dec 12, 2025
bda894c
Fix the syntax for multi-exception rescue
Deer-Spangle Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark the "when viewing a journal post handles non existent journal he… 
…ader" test as skipped, as this is a known and reported FA bug
  • Loading branch information
@Deer-Spangle
Deer-Spangle committed Dec 11, 2025
commit 889c88e0a995e5bd5aed1e8128c08ae3012004f0
1 change: 1 addition & 0 deletions tests/integration/fa_parsing_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,7 @@
end

it "handles non existent journal header" do
skip "Skipped: Current [2025-12-11] FA bug prevents footer from showing if header is unset"
journal_id = "9185944"
journal = @fa.journal(journal_id)
expect(journal[:title]).to eql("Testing journals")
Expand Down
Loading