Fix test runner running too many tests due to unescaped regex patterns #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test runner was incorrectly running all samples that start with a given prefix instead of just the exact sample that changed. For example, when
nextjs-staticwas added in PR #417, the test runner ran tests for all samples starting withnextjsincludingnextjs,nextjs-blog,nextjs-claude,nextjs-cv,nextjs-documentation, andnextjs-postgres.Root Cause
The issue was in the GitHub Actions workflow
deploy-changed-samples.ymlwhere sample names fromchanged_samples.txtwere passed directly to the loadtest tool as regex patterns. Since the loadtest tool treats the-sparameter as regular expressions, unescaped sample names likenextjs-staticwould match any sample containing the substringnextjs.Solution
Modified the workflow to:
awk '{gsub(/[.*+?^${}()|[\]\\]/, "\\\\&")}'^and$to ensure exact matching:^sample-name$This ensures that when a sample like
nextjs-staticchanges, only that exact sample is tested, not all samples withnextjsin their name.Testing
Verified the fix works correctly:
nextjsmatched 6 samples (nextjs, nextjs-blog, nextjs-claude, nextjs-cv, nextjs-documentation, nextjs-postgres)^nextjs$matches only 1 sample (nextjs)python.*for all python samples)Fixes #418.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.