Skip to content

Fix test runner running too many tests due to unescaped regex patterns #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Draft

Fix test runner running too many tests due to unescaped regex patterns #421

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1834b2
Initial plan
Copilot Jul 16, 2025
e9c9bcc
Fix test runner to prevent running too many tests by anchoring sample…
Copilot Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test runner to prevent running too many tests by anchoring sample… 
… name patterns

Co-authored-by: lionello <[email protected]>
  • Loading branch information
@lionello
Copilot and lionello committed Jul 16, 2025
commit e9c9bccee85816116a499c61b0b24b35d79acafa
3 changes: 2 additions & 1 deletion .github/workflows/deploy-changed-samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ jobs:
TEST_SHARED_SECRETS: ${{ secrets.TEST_SHARED_SECRETS}}
TEST_ALLOWED_HOSTS: ${{ secrets.TEST_ALLOWED_HOSTS }}
run: |
SAMPLES=$(sed 's|^samples/||' changed_samples.txt | paste -s -d ',' -)
# Escape regex special characters and anchor patterns to ensure exact matching of sample names
SAMPLES=$(sed 's|^samples/||' changed_samples.txt | awk '{gsub(/[.*+?^${}()|[\]\\]/, "\\\\&"); print "^" $0 "$"}' | paste -s -d ',' -)
echo "Running tests for samples: $SAMPLES"
mkdir output
# concurrency is set to 10 to avoid exhausting our fargate vCPU limits when running
Expand Down