Skip to content

ENG-960 Improve DX for base DG queries #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ENG-960 Improve DX for base DG queries #488

wants to merge 5 commits into from
+650 −160

Conversation

mdroidian
Copy link
Contributor

Example DX improvement (one of many options)

Before
image
image

After
image

image image

@linear Linear
Copy link

linear bot commented Oct 13, 2025

ENG-960 Improve DX for base DG queries

@supabase Supabase
Copy link

supabase bot commented Oct 13, 2025

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mdroidian mdroidian mentioned this pull request Oct 13, 2025
Merged
@maparent maparent self-requested a review October 16, 2025 17:20
@maparent
Copy link
Collaborator

@mdroidian I made a lot of changes. Ideally you should review them, but it seems I cannot make you a reviewer since you're the author. Should I make another branch?

@maparent maparent marked this pull request as ready for review October 16, 2025 17:24
@mdroidian
Copy link
Contributor Author

@mdroidian I made a lot of changes. Ideally you should review them, but it seems I cannot make you a reviewer since you're the author. Should I make another branch?

Looks like it still shows up in my queue, so we are good.

@maparent maparent force-pushed the eng-960-improve-dx-for-base-dg-queries branch 2 times, most recently from 3a4244c to 745edfc Compare October 17, 2025 13:27
mdroidian
mdroidian commented Oct 18, 2025
View reviewed changes
packages/database/src/lib/queries.ts Outdated
* });
* ```
*/
// Main entry point to query Concepts and related data:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason why the JSDoc and @example was removed for getConcepts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that was an inadvertent loss in the rewrite, apologies. Reinstated and expanded.

@maparent maparent force-pushed the eng-960-improve-dx-for-base-dg-queries branch from 3c741ae to bffce97 Compare October 18, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maparent maparent Awaiting requested review from maparent

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

General
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdroidian @maparent