FIX - Correction of new hook PR #31422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Oct 16, 2024
| if ($reshook == 1) { | ||
| // for add information | ||
| $text_info .= $hookmanager->resPrint; | ||
| } elseif ($reshook == 0) { |
Member
There was a problem hiding this comment.
i made an error by validating a new hook into an already released branch. i revert it.
You can submit the hook into develop branch.
Also the fix is not correct. We should have
if ($reshook == 1) { // We replace
// for add information
$text_info = $hookmanager->resPrint;
} elseif ($reshook == 0) { // default action, we add if there is something to add
$text_info .= $hookmanager->resPrint;
eldy
added
the
PR to fix - See feedback in comments
Member
|
It seems this PR was set with "Discussion" or "PR to fix" tag, but no answer nor correction was provided since a long time. So request is automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX - Correction of new hook PR
This PR corrects the PR for adding a new hook. I made the mistake of setting the text_info replacement to $reshook == 0, which is the default value for reshook, which always replaced the given with empty when the hook was not in use.