Skip to content

FIX - Correction of new hook PR #31422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atm-lucasmantegari wants to merge 1 commit into from
Closed

FIX - Correction of new hook PR #31422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion htdocs/commande/list.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2573,7 +2573,7 @@
if ($reshook == 1) {
// for add information
$text_info .= $hookmanager->resPrint;
} elseif ($reshook == 0) {
Copy link
Member

@eldy eldy Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made an error by validating a new hook into an already released branch. i revert it.
You can submit the hook into develop branch.
Also the fix is not correct. We should have


if ($reshook == 1) {   // We replace
						// for add information
						$text_info = $hookmanager->resPrint;
} elseif ($reshook == 0) {     // default action, we add if there is something to add
						$text_info .= $hookmanager->resPrint;

} elseif ($reshook == 2) {
// for replace information
$text_info = $hookmanager->resPrint;
} elseif ($reshook == -1) {
Expand Down