WP Updates #4
Merged
WP Updates #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* convert HTML formatting whitespace to spaces * Adjust and add e2e tests * Visualise consecutive spaces * Update e2e tests
* Add select param to withDispatch HOC * Refactor BlockListBlock component to use select param in withDispatch * Update data documentation to include new param used in withDispatch HOC * Update changelog for data package to include note about updated withDispatch capabilities * Add grammar corrections to data package readme * Refactor CopyHandler component to use select in withDispatch * Ensure that only functions can be returned in the object created by mapDispatchToProps * Use select param in withDispatch for Header component * Address feedback shared in review for WithDispatch component * Update withDispatch to pass registry as 3rd param * Update data package documentation to explain usage of the registry * Refactor CopyHandler to work with onCopy handler exposed from withDispatch * Pass registry as the 3rd param to mapSelectToProps in withSelect * Refactor CopyHandler to use only withDispatch
* Always re-render RichText component when a change happens on Native side * Remove code that blocks updating of the RichText component on undo/redo * Fix lint-js * Add TODO item that better explains next steps to fix/remove re-rendering when not needed
* Packages: Extract Eslint config package * Copy config from eslint-config-wordpress * Docs: Expose documentation for the newly added package * Remove no longer necessary globals from the Eslint config * Apply suggestions from code review Fix ESLint typo Kudos to @ntwb for catching Co-Authored-By: gziolo <[email protected]>
* chore(release): publish - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] * Bump Gutenberg Version to 4.6.0
The file uploads are not working on travis, and our end 2 end tests are failing, we are skipping the test until we find a solution to this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: