Skip to content

Add the possibility to remove multiple views #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2018
Merged

Add the possibility to remove multiple views #8

merged 3 commits into from
Sep 6, 2018

Conversation

@Aymenworks
Copy link
Contributor

@Aymenworks Aymenworks commented Sep 6, 2018

No description provided.

@muukii
Copy link
Collaborator

muukii commented Sep 6, 2018

@Aymenworks
Thank you for requesting feature.
I think added remove function should be aligned to open func remove(view: UIView, animated: Bool).
For example, open func remove(views: [UIView], animated: Bool).
And then in this function, using perofmBatchUpdate to keep performance.
What do you think?

@Aymenworks
Copy link
Contributor Author

Aymenworks commented Sep 6, 2018

Done!

Thanks you for the feedbacks.

muukii
muukii approved these changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@muukii muukii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@muukii muukii merged commit 4b079a5 into FluidGroup:master Sep 6, 2018
JohnEstropia
JohnEstropia reviewed Sep 6, 2018
View reviewed changes
StackScrollView/StackScrollView.swift
}

if animated {
UIView.animate(
Copy link
Contributor

@JohnEstropia JohnEstropia Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but doesn't performBatchUpdates already animate the deletion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnEstropia JohnEstropia JohnEstropia left review comments

@muukii muukii muukii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aymenworks @muukii @JohnEstropia