Skip to content

Add the possibility to remove multiple views #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Add the possibility to remove multiple views #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03ef0b9
Add the possibility to remove multiple views
Aymenworks Sep 6, 2018
736f236
Refactored to align to the current project code style
Aymenworks Sep 6, 2018
cd8333a
Update StackScrollView.swift
Aymenworks Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions StackScrollView/StackScrollView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,50 @@ open class StackScrollView: UICollectionView, UICollectionViewDataSource, UIColl
}
}

open func remove(views: [UIView], animated: Bool) {

var indicesForRemove: [Int] = []

for view in views {
if let index = self.views.index(of: view) {
indicesForRemove.append(index)
}
}

// It seems that the layout is not updated properly unless the order is aligned.
indicesForRemove.sort(by: >)

for index in indicesForRemove {
self.views.remove(at: index)
}

if animated {
UIView.animate(
Copy link
Contributor

@JohnEstropia JohnEstropia Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but doesn't performBatchUpdates already animate the deletion?

withDuration: 0.5,
delay: 0,
usingSpringWithDamping: 1,
initialSpringVelocity: 0,
options: [
.beginFromCurrentState,
.allowUserInteraction,
.overrideInheritedCurve,
.overrideInheritedOptions,
.overrideInheritedDuration
],
animations: {
self.performBatchUpdates({
self.deleteItems(at: indicesForRemove.map { IndexPath.init(item: $0, section: 0) })
}, completion: nil)
})
} else {
UIView.performWithoutAnimation {
performBatchUpdates({
self.deleteItems(at: indicesForRemove.map { IndexPath.init(item: $0, section: 0) })
}, completion: nil)
}
}
}

open func scroll(to view: UIView, animated: Bool) {

let targetRect = view.convert(view.bounds, to: self)
Expand Down