Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the SpecialFunctions package from 1.6 to 1.6, 2.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@DhairyaLGandhi DhairyaLGandhi force-pushed the compathelper/new_version/2021-11-23-00-06-46-855-2771540163 branch from a0da1c6 to 8b9916a Compare November 23, 2021 00:06
@DhairyaLGandhi
Copy link
Member

https://github.com/FluxML/Zygote.jl/runs/4302272011?check_suite_focus=true#step:6:1077 @ChrisRackauckas is there a known breakage with sde layers in the DiffEqFlux tests? Seems like some gradients are expected to be non zero aren't being populated

@ChrisRackauckas
Copy link
Member

That's not a Zygote issue. I need to dig into that one.

@CarloLucibello CarloLucibello merged commit 11597eb into master Nov 26, 2021
@CarloLucibello CarloLucibello deleted the compathelper/new_version/2021-11-23-00-06-46-855-2771540163 branch November 26, 2021 14:26
@DhairyaLGandhi
Copy link
Member

@carlo, PPL tests break with this too, I think we should ask @devmotion if those are known to break as of now.

@devmotion
Copy link
Collaborator

Why was this merged without testing it? There's no rush here, the new version does not contain any new features but only fixes a very old type piracy of factorial. Many packages are not compatible with it yet, eg ForwardDiff and hence also Distributions do not support it yet, and hence it can't be tested here.

@devmotion
Copy link
Collaborator

In any case, thanks for the ping @DhairyaLGandhi! The DynamicPPL test errors are known and caused by Distributions. The latest release of PDMats exposed some bugs, they are fixed in the latest release of Distributions.

@CarloLucibello
Copy link
Member

Sorry for that, I didn't notice that SpecialFunctions was still blocked by upstream packages in test. Can revert if needed, although I think that is not necessary since the release has only very specific breakings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants