-
Notifications
You must be signed in to change notification settings - Fork 66
CompatHelper: bump compat for "SpecialFunctions" to "2" #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for "SpecialFunctions" to "2" #444
Conversation
aae5980 to
58126dd
Compare
|
Blocked by (at least) JuliaStats/Distributions.jl#1434 |
|
It's not blocked, as commented here. |
The latest releases of ForwardDiff and Distributions are compatible with SpecialFunctions 2.0.
On Julia >= 1.7 tests will error if the latest versions of the dependencies that is declared to be compatible can't be installed (see, e.g., https://github.com/JuliaManifolds/Manifolds.jl/runs/4512695265?check_suite_focus=true#step:5:30 and https://github.com/JuliaStats/Distributions.jl/runs/4500903661?check_suite_focus=true#step:6:71). I.e., you have to set |
Right, though now ReverseDiff is still incompatible with SpecialFunctions 2.0: JuliaDiff/ReverseDiff.jl#188 . |
|
I'm on it, I'll merge and tag a new release when tests pass: JuliaDiff/ReverseDiff.jl#188 It took a bit more time since I had to fix some unrelated test errors first. |
|
Thanks for the update! The next one, it seems, is Zygote.jl. |
|
Zygote already merged the SpecialFunctions update without testing it a while ago: FluxML/Zygote.jl#1122 |
|
Yes but they haven't tagged a new version since then. |
|
Another main missing piece (not sure if relevant for Manifolds) is CUDA. However, a new release with SpecialFunctions 2 support is already prepared and will be available soon (hopefully). |
|
I requested a new release (I'm not familiar with Zygote PRs and releases, and hence let more knowledgeable people make a release): FluxML/Zygote.jl#1137 |
|
A new Zygote release will be available soon: JuliaRegistries/General#51051 |
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 97.99% 97.97% -0.02%
==========================================
Files 82 82
Lines 6529 6531 +2
==========================================
+ Hits 6398 6399 +1
- Misses 131 132 +1
Continue to review full report at Codecov.
|
|
Looks good in general, can we shortly check where we lose the one line code coverage? Is that just a misclassification? |
|
This lost coverage may either be due to a minor change in Distributions.jl or just a random error in coverage calculation. I'd just ignore it. |
This pull request changes the compat entry for the
SpecialFunctionspackage from0.8, 0.9, 0.10, 1.0to0.8, 0.9, 0.10, 1.0, 2.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.