Skip to content

Hx20 warning fix #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Hx20 warning fix #27

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4569b48
Add a devcontainer for multiplatform development
pantsman0 Mar 16, 2023
7e911d0
Update Dockerfile to use gcc-10
pantsman0 Mar 20, 2023
e0106fe
Update tasks.json to support building the hx30 board
pantsman0 Mar 20, 2023
ce57bb1
IJKL nav and fnlock LED
pantsman0 Mar 28, 2023
9eee678
Fix hx20 board in line with PR#24
pantsman0 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix hx20 board in line with PR#24 
Fixes the pd response print in the hx20 board, inline with the approved changes for hx30 at #24
  • Loading branch information
@pantsman0
pantsman0 authored Apr 7, 2023
commit 9eee6787c04d322d0973a93129d7c6ab572f3b19
11 changes: 6 additions & 5 deletions board/hx20/cypress5525.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,12 +968,13 @@ void cyp5525_port_int(int controller, int port)
int port_idx = (controller << 1) + port;
enum pd_msg_type sop_type;
rv = i2c_read_offset16_block(i2c_port, addr_flags, CYP5525_PORT_PD_RESPONSE_REG(port), data2, 4);
if (rv != EC_SUCCESS)
if (rv != EC_SUCCESS) {
CPRINTS("PORT_PD_RESPONSE_REG failed");
print_pd_response_code(controller,
port,
data2[0],
data2[1]);
print_pd_response_code(controller,
port,
data2[0],
data2[1]);
}

response_len = data2[1];
switch (data2[0]) {
Expand Down