Fixing used_images usage in summary_json_system_prompt#1109
Merged
jamesbraza merged 2 commits intomainfrom Sep 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes two issues with the used_images attribute in the summary_json_system_prompt: corrects incomplete JSON sample and makes the attribute optional for users who don't need image tracking.
- Separates standard and multimodal JSON prompts to handle
used_imagesappropriately - Updates tests to use multimodal prompt and properly handle boolean conversion
- Adds documentation for the optional multimodal prompt usage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/paperqa/prompts.py | Splits prompt into standard and multimodal versions, fixing JSON format |
| tests/test_paperqa.py | Updates image tests to use multimodal prompt and fix boolean assertions |
| README.md | Documents the optional multimodal prompt configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Related Documentation 1 document(s) may need updating based on files changed in this PR |
b7a017c to
587473a
Compare
whitead
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two problems being fixed here:
"used_images"didn't have a value"used_images"should only be present if you actually want to use this attribute, which most users won't care about