Skip to content

Fixing used_images usage in summary_json_system_prompt #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbraza merged 2 commits into from
Sep 26, 2025
+24 −4
Merged

Fixing used_images usage in summary_json_system_prompt #1109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e071423
Accounting for used_images being a string in tests
jamesbraza Sep 26, 2025
587473a
Moved used_images to only be opted into via summary_json_multimodal_s…
jamesbraza Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Accounting for used_images being a string in tests
  • Loading branch information
@jamesbraza
jamesbraza committed Sep 26, 2025
commit e07142385a08db2ec46a3dd07d20ec84333b7d40
4 changes: 2 additions & 2 deletions tests/test_paperqa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,7 +1623,7 @@ async def test_images(stub_data_dir: Path) -> None:
if c.id in session.used_contexts and c.text.doc == districts_doc
]
assert contexts_used
assert all(c.used_images for c in contexts_used) # type: ignore[attr-defined]
assert all(bool(c.used_images) for c in contexts_used) # type: ignore[attr-defined]


@pytest.mark.asyncio
Expand Down Expand Up @@ -1685,7 +1685,7 @@ async def test_images_corrupt(stub_data_dir: Path) -> None:
if c.id in session.used_contexts and c.text.doc == districts_doc
]
assert contexts_used
assert all(not c.used_images for c in contexts_used) # type: ignore[attr-defined]
assert all(not bool(c.used_images) for c in contexts_used) # type: ignore[attr-defined]


def test_zotero() -> None:
Expand Down