Fixing Settings.get_index_name being the same for different PDF parsers#1125
Merged
jamesbraza merged 1 commit intomainfrom Oct 6, 2025
Merged
Fixing Settings.get_index_name being the same for different PDF parsers#1125jamesbraza merged 1 commit intomainfrom
Settings.get_index_name being the same for different PDF parsers#1125jamesbraza merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where different PDF parsers (PyMuPDF vs PyPDF) would generate the same index name, causing them to clobber each other's cached parsing results.
- Added the PDF parser function as a parameter in index name generation to ensure uniqueness
- Added a test to verify that different parsers produce different index names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/paperqa/settings.py | Modified get_index_name method to include the PDF parser function in the index name calculation |
| tests/test_paperqa.py | Added test case to verify different PDF parsers generate unique index names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Eddie-MG
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are using a PyPDF-based vs a PyMuPDF-based parser, the autogenerated index names should not clobber each other.