Fixing Settings.get_index_name being the same for different PDF parsers

src/paperqa/settings.py

@@ -908,6 +908,7 @@ def get_index_name(self) -> str:
             first_segment,
             str(self.agent.index.use_absolute_paper_directory),
             self.embedding,
+            str(self.parsing.parse_pdf),  # Don't use __name__ as lambda wouldn't differ
             str(self.parsing.chunk_size),
             str(self.parsing.overlap),
             self.parsing.chunking_algorithm,

tests/test_paperqa.py

@@ -1808,6 +1808,18 @@ async def test_context_inner_outer_prompt(stub_data_dir: Path) -> None:
     assert "Valid Keys" not in response.context
 
 
+def test_get_index_name() -> None:
+    settings_pymupdf = Settings(parsing={"parse_pdf": pymupdf_parse_pdf_to_pages})
+    settings_pypdf = Settings(parsing={"parse_pdf": pypdf_parse_pdf_to_pages})
+    names = {settings_pymupdf.get_index_name(), settings_pypdf.get_index_name()}
+    assert (
+        len(names) == 2
+    ), "Expected autogenerated index names to differ if parsers differ"
+    assert all(
+        n.startswith("pqa_index") for n in names
+    ), "Expected index names to be clear they're associated with PaperQA"
+
+
 @pytest.mark.asyncio
 async def test_evidence_detailed_citations_shim(stub_data_dir: Path) -> None:
     # TODO: delete this test in v6