Removing a few chunk_size/overlap references missed in #1160#1161
Merged
jamesbraza merged 2 commits intomainfrom Oct 29, 2025
Merged
Removing a few chunk_size/overlap references missed in #1160#1161jamesbraza merged 2 commits intomainfrom
chunk_size/overlap references missed in #1160#1161jamesbraza merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from deprecated chunk_size and overlap fields in ParsingSettings to their replacements in the reader_config dictionary (chunk_chars and overlap). The changes update three files to use the new dictionary-based configuration instead of the direct field access.
- Updates references from
parsing.chunk_sizetoparsing.reader_config["chunk_chars"] - Updates references from
parsing.overlaptoparsing.reader_config["overlap"] - Refactors chunking logic in
openreview_paper_helper.pyfor better readability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_agents.py | Updates test assertion to use new reader_config["chunk_chars"] instead of deprecated chunk_size |
| src/paperqa/settings.py | Updates index name generation to use reader_config dictionary values instead of deprecated fields |
| src/paperqa/contrib/openreview_paper_helper.py | Refactors submission string chunking to extract chunk_size from reader_config and improves code readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a29acec to
2702bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rushed #1160 trying to unblock something