Skip to content

Removing a few chunk_size/overlap references missed in #1160#1161

Merged
jamesbraza merged 2 commits intomainfrom
missed-chunk-size-deps
Oct 29, 2025
Merged

Removing a few chunk_size/overlap references missed in #1160#1161
jamesbraza merged 2 commits intomainfrom
missed-chunk-size-deps

Conversation

@jamesbraza
Copy link
Copy Markdown
Collaborator

@jamesbraza jamesbraza commented Oct 29, 2025

I rushed #1160 trying to unblock something

@jamesbraza jamesbraza self-assigned this Oct 29, 2025
Copilot AI review requested due to automatic review settings October 29, 2025 20:51
@jamesbraza jamesbraza added the bug Something isn't working label Oct 29, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 29, 2025
@dosubot
Copy link
Copy Markdown

dosubot bot commented Oct 29, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from deprecated chunk_size and overlap fields in ParsingSettings to their replacements in the reader_config dictionary (chunk_chars and overlap). The changes update three files to use the new dictionary-based configuration instead of the direct field access.

  • Updates references from parsing.chunk_size to parsing.reader_config["chunk_chars"]
  • Updates references from parsing.overlap to parsing.reader_config["overlap"]
  • Refactors chunking logic in openreview_paper_helper.py for better readability

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/test_agents.py Updates test assertion to use new reader_config["chunk_chars"] instead of deprecated chunk_size
src/paperqa/settings.py Updates index name generation to use reader_config dictionary values instead of deprecated fields
src/paperqa/contrib/openreview_paper_helper.py Refactors submission string chunking to extract chunk_size from reader_config and improves code readability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamesbraza jamesbraza force-pushed the missed-chunk-size-deps branch from a29acec to 2702bd9 Compare October 29, 2025 21:15
@jamesbraza jamesbraza merged commit e837ebe into main Oct 29, 2025
7 checks passed
@jamesbraza jamesbraza deleted the missed-chunk-size-deps branch October 29, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants