Fixed chunk_size/overlap references missed in #1160

src/paperqa/contrib/openreview_paper_helper.py

@@ -89,12 +89,11 @@ async def fetch_relevant_papers(self, question: str) -> dict[str, Any]:
         submissions = self.get_submissions()
         submission_string = self.create_submission_string(submissions)
 
-        if len(submission_string) > self.settings.parsing.chunk_size:
+        chunk_size = self.settings.parsing.reader_config["chunk_chars"]
+        if len(submission_string) > chunk_size:
             chunks = [
-                submission_string[i : i + self.settings.parsing.chunk_size]
-                for i in range(
-                    0, len(submission_string), self.settings.parsing.chunk_size
-                )
+                submission_string[i : i + chunk_size]
+                for i in range(0, len(submission_string), chunk_size)
             ]
         else:
             chunks = [submission_string]

src/paperqa/settings.py

@@ -972,8 +972,8 @@ def get_index_name(self) -> str:
             str(self.agent.index.use_absolute_paper_directory),
             self.embedding,
             str(self.parsing.parse_pdf),  # Don't use __name__ as lambda wouldn't differ
-            str(self.parsing.chunk_size),
-            str(self.parsing.overlap),
+            str(self.parsing.reader_config["chunk_chars"]),
+            str(self.parsing.reader_config["overlap"]),
             self.parsing.chunking_algorithm,
             str(self.parsing.multimodal),
         ]

tests/test_agents.py

@@ -529,7 +529,7 @@ async def test_propagate_options(agent_test_settings: Settings) -> None:
     assert len(result.contexts) >= 2, "Test expects a few contexts"
     # Subtract 2 to allow tolerance for chunks with leading/trailing whitespace
     num_contexts_sufficient_length = sum(
-        len(c.context) >= agent_test_settings.parsing.chunk_size - 2
+        len(c.context) >= agent_test_settings.parsing.reader_config["chunk_chars"] - 2
         for c in result.contexts
     )
     # Check most contexts have the expected length