Logging tool name in NemotronBBoxError/NemotronLengthError#1279
Merged
jamesbraza merged 1 commit intomainfrom Jan 29, 2026
Merged
Logging tool name in NemotronBBoxError/NemotronLengthError#1279jamesbraza merged 1 commit intomainfrom
NemotronBBoxError/NemotronLengthError#1279jamesbraza merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances error messages for debugging by adding the tool name to NemotronLengthError and NemotronBBoxError exceptions. This improves traceability when errors occur during API calls.
Changes:
- Added tool name to
NemotronLengthErrorerror messages in both NVIDIA and SageMaker API call functions - Added tool name to
NemotronBBoxErrorerror messages in both NVIDIA and SageMaker API call functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for traceability/debugging
Note
Low Risk
Only adjusts exception message strings to add context; no functional changes to request/response handling or retry logic.
Overview
Improves error traceability in
paperqa_nemotron/api.pyby including the originatingtool_namein exception messages forNemotronLengthError(when the model returnsfinish_reason == "length") andNemotronBBoxError(when tool-call arguments fail Pydantic validation).This is applied consistently across both the Nvidia API and SageMaker execution paths, without changing control flow or parsing behavior.
Written by Cursor Bugbot for commit 4bc4104. Configure here.