Skip to content

Logging tool name in NemotronBBoxError/NemotronLengthError #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbraza merged 1 commit into from
Jan 29, 2026
Merged

Logging tool name in NemotronBBoxError/NemotronLengthError #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/paper-qa-nemotron/src/paperqa_nemotron/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ async def _call_nvidia_api(
)
if response.choices[0].finish_reason == "length":
raise NemotronLengthError(
f"Model response {response} indicates the input"
f"Model response {response} from tool {tool_name!r} indicates the input"
f" image of shape {image.shape} is too large or the model started babbling.",
response.choices[0], # Include if callers want
)
Expand All @@ -463,7 +463,8 @@ async def _call_nvidia_api(
assert_never(tool_name)
except ValidationError as exc:
raise NemotronBBoxError(
f"nemotron-parse response {args_json} has invalid bounding box."
f"nemotron-parse response {args_json} from tool {tool_name!r}"
" has invalid bounding box."
) from exc
return response

Expand Down Expand Up @@ -576,7 +577,7 @@ async def _call_sagemaker_api(
)
if response.choices[0].finish_reason == "length":
raise NemotronLengthError(
f"Model response {response} indicates the input"
f"Model response {response} from tool {tool_name!r} indicates the input"
f" image of shape {image.shape} is too large or the model started babbling.",
response.choices[0], # Include if callers want
)
Expand All @@ -601,6 +602,7 @@ async def _call_sagemaker_api(
assert_never(tool_name)
except ValidationError as exc:
raise NemotronBBoxError(
f"nemotron-parse response {args_json} has invalid bounding box."
f"nemotron-parse response {args_json} from tool {tool_name!r}"
" has invalid bounding box."
) from exc
return response
Loading