Skip to content

Fixing test_parse_office_doc by modernizing Gemini model#1286

Merged
jamesbraza merged 1 commit intomainfrom
latest-gemini
Feb 11, 2026
Merged

Fixing test_parse_office_doc by modernizing Gemini model#1286
jamesbraza merged 1 commit intomainfrom
latest-gemini

Conversation

@jamesbraza
Copy link
Copy Markdown
Collaborator

@jamesbraza jamesbraza commented Feb 11, 2026

From https://developers.googleblog.com/gemini-embedding-available-gemini-api/:

Legacy models will also be deprecated in the coming months:

  • ...
  • text-embedding-004 on January 14, 2026

This PR just modernizes the model for test_parse_office_doc to the latest gemini/gemini-embedding-001


Note

Low Risk
Test-only change that updates a model identifier; main risk is CI flakiness if the new embedding model behaves differently or has different availability/quotas.

Overview
Updates test_parse_office_doc to use gemini/gemini-embedding-001 instead of the deprecated gemini/text-embedding-004 embedding model, keeping the rest of the Gemini LLM configuration unchanged.

Written by Cursor Bugbot for commit b8c7969. Configure here.

@jamesbraza jamesbraza self-assigned this Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 06:07
@jamesbraza jamesbraza added the bug Something isn't working label Feb 11, 2026
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 11, 2026
@dosubot
Copy link
Copy Markdown

dosubot bot commented Feb 11, 2026

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Gemini embedding model used by test_parse_office_doc to address a failing test by modernizing the model configuration.

Changes:

  • Switch test_parse_office_doc embedding model from gemini/text-embedding-004 to gemini/gemini-embedding-001.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

settings = Settings(
llm="gemini/gemini-2.5-flash",
embedding="gemini/text-embedding-004",
embedding="gemini/gemini-embedding-001",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description references Gemini embedding model text-embedding-004, but this change switches the test to gemini-embedding-001. This is inconsistent with the rationale given in the PR description and also diverges from the README’s Gemini example (README.md:578 uses gemini/text-embedding-004). Please either (a) update the test to the intended model from the PR description, or (b) update the PR description (and ideally the README example in a follow-up/this PR) to match the new recommended embedding model name.

Copilot uses AI. Check for mistakes.
@jamesbraza jamesbraza merged commit ff4c740 into main Feb 11, 2026
10 of 14 checks passed
@jamesbraza jamesbraza deleted the latest-gemini branch February 11, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants