Fixing test_parse_office_doc by modernizing Gemini model#1286
Fixing test_parse_office_doc by modernizing Gemini model#1286jamesbraza merged 1 commit intomainfrom
test_parse_office_doc by modernizing Gemini model#1286Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Gemini embedding model used by test_parse_office_doc to address a failing test by modernizing the model configuration.
Changes:
- Switch
test_parse_office_docembedding model fromgemini/text-embedding-004togemini/gemini-embedding-001.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| settings = Settings( | ||
| llm="gemini/gemini-2.5-flash", | ||
| embedding="gemini/text-embedding-004", | ||
| embedding="gemini/gemini-embedding-001", |
There was a problem hiding this comment.
The PR description references Gemini embedding model text-embedding-004, but this change switches the test to gemini-embedding-001. This is inconsistent with the rationale given in the PR description and also diverges from the README’s Gemini example (README.md:578 uses gemini/text-embedding-004). Please either (a) update the test to the intended model from the PR description, or (b) update the PR description (and ideally the README example in a follow-up/this PR) to match the new recommended embedding model name.
From https://developers.googleblog.com/gemini-embedding-available-gemini-api/:
This PR just modernizes the model for
test_parse_office_docto the latestgemini/gemini-embedding-001Note
Low Risk
Test-only change that updates a model identifier; main risk is CI flakiness if the new embedding model behaves differently or has different availability/quotas.
Overview
Updates
test_parse_office_docto usegemini/gemini-embedding-001instead of the deprecatedgemini/text-embedding-004embedding model, keeping the rest of the Gemini LLM configuration unchanged.Written by Cursor Bugbot for commit b8c7969. Configure here.