Skip to content

Fixing test_parse_office_doc by modernizing Gemini model #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbraza merged 1 commit into from
Feb 11, 2026
Merged

Fixing test_parse_office_doc by modernizing Gemini model #1286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_paperqa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3402,7 +3402,7 @@ async def test_parse_office_doc(stub_data_dir: Path, filename: str, query: str)

settings = Settings(
llm="gemini/gemini-2.5-flash",
embedding="gemini/text-embedding-004",
embedding="gemini/gemini-embedding-001",
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description references Gemini embedding model text-embedding-004, but this change switches the test to gemini-embedding-001. This is inconsistent with the rationale given in the PR description and also diverges from the README’s Gemini example (README.md:578 uses gemini/text-embedding-004). Please either (a) update the test to the intended model from the PR description, or (b) update the PR description (and ideally the README example in a follow-up/this PR) to match the new recommended embedding model name.

Copilot uses AI. Check for mistakes.
summary_llm="gemini/gemini-2.5-flash",
agent={"agent_llm": "gemini/gemini-2.5-flash"},
parsing=ParsingSettings(use_doc_details=False),
Expand Down
Loading