feat: Input error when a box does not select anything #3808

arng40 · 2025-09-05T13:40:52Z

When a box (usually a user-defined volume) is not selected and the deck does not involve a SurfaceGenerator, the simulation is stopped and output an error.

***** Controlling expression (should be false): true
***** Rank 0: bcPressure (thermalLeakyWell_base.xml, l.168): this FieldSpecification targets (an) empty set(s).
Set 'east':
 - Does not capture: ElementRegions/aquiferBottom
 - Instead, captures: faceManager, edgeManager, nodeManager
Set 'north':
 - Does not capture: ElementRegions/aquiferBottom
 - Instead, captures: faceManager, edgeManager, nodeManager
Set 'south':
 - Does not capture: ElementRegions/aquiferBottom
 - Instead, captures: faceManager, edgeManager, nodeManager
Set 'west':
 - Does not capture: ElementRegions/aquiferBottom
 - Instead, captures: faceManager, edgeManager, nodeManager

The user can precise this error state by adding a errorSetMode in the targeted FieldSpecification wrapper with "silent|warning|error".

Also update the example on 5 units tests where the box defined didn't include the targeted mesh.

Edited the Thermal Leaky Well example. The smoke version of this was not implementing the boundary conditions correctly. These have been changed from element based to face based boundary conditions so that they are applicable to both the smoke and benchmark cases. This case has also changed similar to issue #3660. The images have therefore been updated to the current values.

paveltomin

i am ok with the change but you will need to update all the hydrofrac inputs...

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp

…hen-box-select-nothing

herve-gross · 2025-10-08T15:36:34Z

@castelletto1 @corbett5 @bd713 : this one needs your help because the CI does not pass, and @arng40 does not understand why. Thank you!

bd713 · 2025-10-08T15:59:38Z

@castelletto1 @corbett5 @bd713 : this one needs your help because the CI does not pass, and @arng40 does not understand why. Thank you!

When comparing with the reference result, the CI detects that we have introduced a new errorSetMode.
As a result, it sees the outputs as different and considers the test failed... even though the numerical results themselves are likely unchanged.

…hen-box-select-nothing

rrsettgast · 2025-10-09T17:29:14Z

@arng40
There seem to be some non-trivial changes to the xml files, which may be leading to some of your integratedTest fails. Please revert those changes back to get a valid test result. Then you can change them and rebaseline once you verify that you haven't introduced a diff through code changes.

many new changes

castelletto1 · 2025-10-09T20:30:14Z

As @bd713 pointed out, all integrated tests have restart hdf5 files that show a structural change due to addition of setErrorMode, precisely:

"Group has a child 'errorSetMode' in the file to compare but not the baseline file."

The only two tests that show numerical diffs are:

/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/thermalLeakyWell_smoke_3d_04/0162.python3_thermalLeakyWell_smoke_3d_04_2_restartcheck_.log
/compositionalMultiphaseFlow/benchmarks/thermalLeakyWell/thermalLeakyWell_smoke_3d_01/0158.python3_thermalLeakyWell_smoke_3d_01_2_restartcheck_.log

Given the PR description:

Edited the Thermal Leaky Well example. The smoke version of this was not implementing the boundary conditions correctly. These have been changed from element based to face based boundary conditions so that they are applicable to both the smoke and benchmark cases. This case has also changed similar to issue #3660. The images have therefore been updated to the current values.

... it’s not surprising to see numerical diffs in these two tests.

Unless I am missing something, I would say we are good to go.

arng40 · 2025-10-10T13:30:33Z

With the revert of thermalLeakyWell and the script set to "errorSetMode" I've got

INFO: Total number of log files processed: 1041

INFO: No unfiltered differences were found.

INFO: The following file(s) had at least one error block that was filtered:

This reverts commit 874186b.

…hen-box-select-nothing

paveltomin · 2025-10-10T13:55:55Z

does https://geosx-geosx.readthedocs-hosted.com/en/latest/docs/sphinx/advancedExamples/validationStudies/carbonStorage/thermalLeakyWell/Example.html need to be updated?

paveltomin · 2025-10-10T13:57:19Z

src/coreComponents/dataRepository/Group.cpp

  {
    GEOS_LOG( string( indent, '\t' ) << "-> " << view.second->getName() << " : "
-                                     << LvArray::system::demangleType( *view.second ) );
+                                     << LvArray::system::demangleType( *view.second ) << " size : "<<view.second->size());


add spaces to keep formatting consistent

paveltomin · 2025-10-10T13:57:48Z

src/coreComponents/fieldSpecification/FieldSpecificationBase.cpp

+  registerWrapper( viewKeyStruct::errorSetModeString(), &m_emptySetErrorMode ).
+    setInputFlag( InputFlags::OPTIONAL ).
+    setApplyDefaultValue( SetErrorMode::error ).
+    setDescription( "Set the log state when we a “set” does not target any region\n"


remove "we"

paveltomin · 2025-10-10T13:58:16Z

src/coreComponents/fieldSpecification/FieldSpecificationBase.cpp

+    setDescription( "Set the log state when we a “set” does not target any region\n"
+                    "When set to \"silent\", no output\n"
+                    "When set to \"warning\", output an error\n"
+                    "When set to \"error\", output a throw\n" );


????
and "error" above

paveltomin · 2025-10-10T13:58:54Z

src/coreComponents/fieldSpecification/FieldSpecificationBase.hpp

  /// The name of a function used to turn on and off the boundary condition.
  string m_bcApplicationFunctionName;

+  /// Value indicating whether we converts an error into a warning


paveltomin · 2025-10-10T14:03:26Z

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp

 void FieldSpecificationManager::validateBoundaryConditions( MeshLevel & mesh ) const
 {
+  DomainPartition const & domain = this->getGroupByPath< DomainPartition >( "/Problem/domain" );
+  Group const & meshBodies = domain.getMeshBodies();


is this needed?

removed the duplication and let this one

paveltomin · 2025-10-10T14:04:29Z

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp

-          targetGroup.getName() == MeshLevel::groupStructKeys::faceManagerString() ) // the field names of the face BCs are not always
-                                                                                     // registered on
-                                                                                     // the faceManager...
+      if( targetGroup.hasWrapper( fieldName ) ||flag == InputFlags::FALSE ||


paveltomin · 2025-10-10T14:13:14Z

does https://geosx-geosx.readthedocs-hosted.com/en/latest/docs/sphinx/advancedExamples/validationStudies/carbonStorage/thermalLeakyWell/Example.html need to be updated?

oh i see it was indeed updated...

…hen-box-select-nothing

set an error when a box has no selection

2c3a2a7

arng40 requested review from CusiniM, MelReyCG, OmarDuran, castelletto1, corbett5, cssherman, dkachuma, herve-gross, jhuang2601, paveltomin, rrsettgast and wrtobin as code owners September 5, 2025 13:40

arng40 changed the title ~~set an error when a box has no selection~~ feat: Input error when a box does not select anything Sep 5, 2025

arng40 self-assigned this Sep 5, 2025

arng40 added type: feature New feature or request flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input labels Sep 5, 2025

arng40 added 2 commits September 5, 2025 15:52

fix

bfe7b49

string correction viewkeystruct

82055c1

paveltomin previously approved these changes Sep 5, 2025

View reviewed changes

MelReyCG requested changes Sep 5, 2025

View reviewed changes

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp Outdated Show resolved Hide resolved

revert changement on dataContext

94104fb

herve-gross approved these changes Sep 5, 2025

View reviewed changes

MelReyCG reviewed Sep 8, 2025

View reviewed changes

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/develop' into feat/dudes/error-w…

c125ae2

…hen-box-select-nothing

arng40 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Sep 8, 2025

arng40 added 2 commits September 8, 2025 13:40

test for cuda

b1fe1a0

fix sink selection in test unit test

37bc92d

Merge remote-tracking branch 'origin/develop' into feat/dudes/error-w…

a5f2a43

…hen-box-select-nothing

paveltomin self-requested a review October 9, 2025 17:29

revert thermalLeakyWell

874186b

arng40 added 2 commits October 10, 2025 15:33

Revert "revert thermalLeakyWell"

2886078

This reverts commit 874186b.

Merge remote-tracking branch 'origin/develop' into feat/dudes/error-w…

4b3161a

…hen-box-select-nothing

paveltomin reviewed Oct 10, 2025

View reviewed changes

paveltomin approved these changes Oct 10, 2025

View reviewed changes

arng40 added 4 commits October 10, 2025 16:47

address typo, duplcation & description

562842f

Merge remote-tracking branch 'origin/develop' into feat/dudes/error-w…

181e571

…hen-box-select-nothing

Merge remote-tracking branch 'origin/develop' into feat/dudes/error-w…

03c20b2

…hen-box-select-nothing

rebaseline

7c79821

MelReyCG approved these changes Oct 13, 2025

View reviewed changes

jhuang2601 approved these changes Oct 13, 2025

View reviewed changes

acitrain approved these changes Oct 13, 2025

View reviewed changes

MelReyCG merged commit 2d40255 into develop Oct 13, 2025
25 of 26 checks passed

MelReyCG deleted the feat/dudes/error-when-box-select-nothing branch October 13, 2025 15:20

feat: Input error when a box does not select anything #3808

feat: Input error when a box does not select anything #3808

Uh oh!

Conversation

arng40 commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paveltomin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

herve-gross commented Oct 8, 2025

Uh oh!

bd713 commented Oct 8, 2025

Uh oh!

rrsettgast commented Oct 9, 2025

Uh oh!

castelletto1 commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arng40 commented Oct 10, 2025

Uh oh!

paveltomin commented Oct 10, 2025

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

arng40 Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

paveltomin commented Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

arng40 commented Sep 5, 2025 •

edited

Loading

castelletto1 commented Oct 9, 2025 •

edited

Loading