feat: Input error when a box does not select anything

src/coreComponents/dataRepository/DataContext.cpp

@@ -108,6 +108,12 @@ string DataFileContext::toString() const
   }
 }
 
+size_t DataFileContext::getLine() const
+{
+  return m_line;
+}
+
+
 DataContext::ToStringInfo DataFileContext::getToStringInfo() const
 { return ToStringInfo( m_targetName, m_filePath, m_line ); }
 

src/coreComponents/dataRepository/DataContext.hpp

@@ -70,6 +70,11 @@ class DataContext
    */
   friend std::ostream & operator<<( std::ostream & os, const DataContext & ctx );
 
+  /**
+   * @return the line (starting from 1) where the target object has been declared in the source file.
+   */
+  virtual size_t getLine() const = 0;
+
 protected:
   // GroupContext & WrapperContext are friend class to be able to access to the protected method on other instances.
   friend class GroupContext;
@@ -170,8 +175,7 @@ class DataFileContext final : public DataContext
   /**
    * @return the line (starting from 1) where the target object has been declared in the source file.
    */
-  size_t getLine() const
-  { return m_line; }
+  size_t getLine() const override;
 
   /**
    * @return the character offset in the line (starting from 1) where the target object has been

src/coreComponents/dataRepository/GroupContext.cpp

@@ -57,6 +57,11 @@ string GroupContext::toString() const
 DataContext::ToStringInfo GroupContext::getToStringInfo() const
 { return ToStringInfo( m_targetName ); }
 
+size_t GroupContext::getLine() const
+{
+  return m_group.getDataContext().getToStringInfo().m_line;
+}
+
 
 } /* namespace dataRepository */
 } /* namespace geos */

src/coreComponents/dataRepository/GroupContext.hpp

@@ -72,6 +72,11 @@ class GroupContext : public DataContext
    * @copydoc DataContext::getToStringInfo()
    */
   ToStringInfo getToStringInfo() const override;
+
+  /**
+   * @copydoc DataContext::getLine()
+   */
+  size_t getLine() const override;
 };
 
 

src/coreComponents/dataRepository/WrapperContext.cpp

@@ -38,6 +38,11 @@ string WrapperContext::toString() const
          GEOS_FMT( "{}/{}", m_group.getDataContext().toString(), m_typeName );
 }
 
+size_t WrapperContext::getLine() const
+{
+  return m_group.getDataContext().getToStringInfo().m_line;
+}
+
 
 } /* namespace dataRepository */
 } /* namespace geos */

src/coreComponents/dataRepository/WrapperContext.hpp

@@ -54,6 +54,11 @@ class WrapperContext final : public GroupContext
    */
   string toString() const override;
 
+  /**
+   * @copydoc DataContext::getLine()
+   */
+  size_t getLine() const override;
+
 };
 
 

src/coreComponents/fieldSpecification/FieldSpecificationBase.cpp

@@ -81,6 +81,11 @@ FieldSpecificationBase::FieldSpecificationBase( string const & name, Group * par
     setApplyDefaultValue( 1.0e99 ).
     setInputFlag( InputFlags::OPTIONAL ).
     setDescription( "Time at which the boundary condition will stop being applied." );
+
+  registerWrapper( viewKeyStruct::errorAsWarningString(), &m_errorAsWarning ).
+    setApplyDefaultValue( 1 ).
+    setInputFlag( InputFlags::OPTIONAL ).
+    setDescription( "Converts an error into a warning" );
 }
 
 

src/coreComponents/fieldSpecification/FieldSpecificationBase.hpp

@@ -392,6 +392,8 @@ class FieldSpecificationBase : public dataRepository::Group
     constexpr static char const * beginTimeString() { return "beginTime"; }
     /// @return The key for endTime
     constexpr static char const * endTimeString() { return "endTime"; }
+    /// @return The key errorAsWarning
+    constexpr static char const * errorAsWarningString() { return "errorAsWarning"; }
   };
 
   /**
@@ -547,6 +549,11 @@ class FieldSpecificationBase : public dataRepository::Group
     return *(m_meshObjectPaths.get());
   }
 
+  integer getErrorAsWarning() const
+  {
+    return m_errorAsWarning;
+  }
+
 
 protected:
 
@@ -591,6 +598,8 @@ class FieldSpecificationBase : public dataRepository::Group
   /// The name of a function used to turn on and off the boundary condition.
   string m_bcApplicationFunctionName;
 
+  /// Value indicating whether we converts an error into a warning
+  integer m_errorAsWarning;
 };
 
 

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp

@@ -237,14 +237,38 @@ void FieldSpecificationManager::validateBoundaryConditions( MeshLevel & mesh ) c
       GEOS_THROW( setNamesError, InputError );
     }
 
-    // if a target set is empty, we issue a warning
-    // ideally we would just stop the simulation, but the SurfaceGenerator relies on this behavior
+    GeometricObjectManager & geometricObjManager = GeometricObjectManager::getInstance();
+
     for( auto const & mapEntry : isTargetSetEmpty )
     {
-      GEOS_LOG_RANK_0_IF( ( mapEntry.second == 1 ), // target set is empty
-                          GEOS_FMT( "\nWarning!\n{}: this FieldSpecification targets (an) empty set(s)"
-                                    "\nIf the simulation does not involve the SurfaceGenerator, check the content of the set `{}` in `{}`. \n",
-                                    fs.getDataContext(), mapEntry.first, fs.getObjectPath() ) );
+      if( mapEntry.second == 1 )
+      {
+        geometricObjManager.forSubGroups< SimpleGeometricObjectBase >(
+          [&]( SimpleGeometricObjectBase const & object )
+        {
+          if( mapEntry.first == object.getName())
+          {
+            std::ostringstream message;
+            message << GEOS_FMT( "{}: this FieldSpecification targets (an) empty set(s)\n"
+                                 "The box {} does not select any region.\n"
+                                 "If the simulation does not involve the SurfaceGenerator, check the content of the set `{}` in `{}`.\n",
+                                 fs.getDataContext(), object.getDataContext(),
+                                 mapEntry.first, fs.getObjectPath());
+            if( fs.getErrorAsWarning() )
+            {
+              std::stringstream line;
+              line << fs.getDataContext().getLine();
+              message << GEOS_FMT( "You can set `errorAsWarning` (l. {}) to `0` to disable the error.",
+                                   line.str() );
+              GEOS_ERROR( message.str() );
+            }
+            else
+            {
+              GEOS_WARNING( message.str() );
+            }
+          }
+        } );
+      }
     }
 
     if( isFieldNameFound == 0 )