Skip to content

added option to disable gitversiontask on build #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DerAlbertCom wants to merge 5 commits into from
Closed

added option to disable gitversiontask on build #1724

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6f92b4
added option to disable gitversiontask on build
DerAlbertCom Jun 27, 2019
f126e43
added unit test for the GitVersionTask property override
DerAlbertCom Jun 27, 2019
efaaa8c
fixed unit test for GitVersionTask Properties for the NUnitRun in bui…
DerAlbertCom Jun 27, 2019
b592d78
disabled the GitVersionTask Properties on mono,
DerAlbertCom Jun 27, 2019
44f51ca
added better way for creating the ProjectXML for MS Buil Task Tests.
DerAlbertCom Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added better way for creating the ProjectXML for MS Buil Task Tests. 
- idea from #1724 (comment)
- made the NUnit workaround obsolete
  • Loading branch information
@DerAlbertCom
DerAlbertCom committed Jun 28, 2019
commit 44f51caf6e3b94cd2ccdc38475da0ef344cb3643
36 changes: 22 additions & 14 deletions src/GitVersionTask.Tests/GitVersionTaskPropertiesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,27 @@ namespace GitVersionTask.Tests
[TestFixture]
public class GitVersionTaskPropertiesTests
{
const string projectXml =
@"<Project xmlns='http://schemas.microsoft.com/developer/msbuild/2003'>
<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<Configuration>Debug</Configuration>
<GitVersionTaskRoot>..\GitVersionTask\build\</GitVersionTaskRoot>
<GitVersionTaskRoot Condition=""!Exists('$(GitVersionTaskRoot)GitVersionTask.props')"">.\src\GitVersionTask\build\</GitVersionTaskRoot>
<GitVersionAssemblyFile>..\..\GitVersionTask.MsBuild\bin\$(Configuration)\$(TargetFramework)\GitVersionTask.MsBuild.dll</GitVersionAssemblyFile>
</PropertyGroup>
<Import Project='$(GitVersionTaskRoot)GitVersionTask.props'/>
<Import Project='$(GitVersionTaskRoot)GitVersionTask.targets'/>


static string CreateProjectXml()
{
var currentDirectory = AppDomain.CurrentDomain.BaseDirectory;
return $@"
<Project xmlns='http://schemas.microsoft.com/developer/msbuild/2003'>
<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<Configuration>Debug</Configuration>
<GitVersionTaskRoot>{currentDirectory}\..\..\..\..\GitVersionTask\build\</GitVersionTaskRoot>
<GitVersionAssemblyFile>{currentDirectory}\..\..\GitVersionTask.MsBuild\bin\$(Configuration)\$(TargetFramework)\GitVersionTask.MsBuild.dll</GitVersionAssemblyFile>
</PropertyGroup>
<Import Project='$(GitVersionTaskRoot)GitVersionTask.props'/>
<Import Project='$(GitVersionTaskRoot)GitVersionTask.targets'/>
</Project>";
}

(bool failed, Project project) CallMsBuild(IDictionary<string, string> globalProperties)
{
using (var stringReader = new StringReader(projectXml))
using (var stringReader = new StringReader(CreateProjectXml()))
{
StringBuilder builder;
Project project;
Expand All @@ -48,8 +53,11 @@ public class GitVersionTaskPropertiesTests
collection.UnregisterAllLoggers();
}

var consoleOutput = builder.ToString();
Console.WriteLine(consoleOutput);
if (!result)
{
var consoleOutput = builder.ToString();
TestContext.Error.Write(consoleOutput);
}

return (!result, project);
}
Expand Down