Skip to content

added option to disable gitversiontask on build #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DerAlbertCom wants to merge 5 commits into from
Closed

added option to disable gitversiontask on build #1724

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6f92b4
added option to disable gitversiontask on build
DerAlbertCom Jun 27, 2019
f126e43
added unit test for the GitVersionTask property override
DerAlbertCom Jun 27, 2019
efaaa8c
fixed unit test for GitVersionTask Properties for the NUnitRun in bui…
DerAlbertCom Jun 27, 2019
b592d78
disabled the GitVersionTask Properties on mono,
DerAlbertCom Jun 27, 2019
44f51ca
added better way for creating the ProjectXML for MS Buil Task Tests.
DerAlbertCom Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
added option to disable gitversiontask on build 
- this is for #1723
- setting the DisableGitVersionTask property to true disables all activities if needed (e.g. NCrunch)
- there is no conditional disabling in the .props file because it must have priority and simple disable it
  • Loading branch information
@DerAlbertCom
DerAlbertCom committed Jun 28, 2019
commit d6f92b4813d351b02e4d7a390fcde24aaa6e6122
9 changes: 9 additions & 0 deletions src/GitVersionTask/build/GitVersionTask.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,25 @@

<GitVersion_NoFetchEnabled Condition="$(GitVersion_NoFetchEnabled) == ''">false</GitVersion_NoFetchEnabled>

<DisableGitVersionTask Condition=" '$(DisableGitVersionTask)' == '' ">false</DisableGitVersionTask>

<!-- Property that enables WriteVersionInfoToBuildLog -->
<WriteVersionInfoToBuildLog Condition=" '$(DisableGitVersionTask)' == 'true' ">false</WriteVersionInfoToBuildLog>
<WriteVersionInfoToBuildLog Condition=" '$(WriteVersionInfoToBuildLog)' == '' ">true</WriteVersionInfoToBuildLog>

<!-- Property that enables UpdateAssemblyInfo. Default to off for SDK builds -->
<UpdateAssemblyInfo Condition=" '$(DisableGitVersionTask)' == 'true' ">false</UpdateAssemblyInfo>
<UpdateAssemblyInfo Condition=" '$(UpdateAssemblyInfo)' == '' ">true</UpdateAssemblyInfo>

<!-- Property that enables GenerateGitVersionInformation -->
<GenerateGitVersionInformation Condition=" '$(DisableGitVersionTask)' == 'true' ">false</GenerateGitVersionInformation>
<GenerateGitVersionInformation Condition=" '$(GenerateGitVersionInformation)' == '' ">true</GenerateGitVersionInformation>

<!-- Property that enables GetVersion -->
<GetVersion Condition=" '$(DisableGitVersionTask)' == 'true' ">false</GetVersion>
<GetVersion Condition=" '$(GetVersion)' == '' ">true</GetVersion>

<GenerateGitVersionWixDefines Condition=" '$(DisableGitVersionTask)' == 'true' ">false</GenerateGitVersionWixDefines>
<GenerateGitVersionWixDefines Condition=" '$(GenerateGitVersionWixDefines)' == '' ">true</GenerateGitVersionWixDefines>
<!--
Ensure GetVersion runs prior to XAML's Markup Compiler in order to have the assembly version available.
Expand All @@ -31,7 +38,9 @@
<GetPackageVersionDependsOn>$(GetPackageVersionDependsOn);GetVersion</GetPackageVersionDependsOn>

<!-- Property that enables setting of Version -->
<UpdateVersionProperties Condition=" '$(DisableGitVersionTask)' == 'true' ">false</UpdateVersionProperties>
<UpdateVersionProperties Condition=" '$(UpdateVersionProperties)' == '' ">true</UpdateVersionProperties>
<UseFullSemVerForNuGet Condition=" '$(DisableGitVersionTask)' == 'true' ">false</UseFullSemVerForNuGet>
<UseFullSemVerForNuGet Condition=" '$(UseFullSemVerForNuGet)' == '' ">false</UseFullSemVerForNuGet>
</PropertyGroup>
</Project>