Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
4a9fa96
Add Microsoft.Extensions.DependencyInjection
arturcic Oct 17, 2019
ff811ea
Add Microsoft.Extensions.Hosting
arturcic Oct 17, 2019
83d002a
Register types in each module
arturcic Oct 20, 2019
8895c6c
refactored ExecCommand and ExecuteCore
arturcic Oct 21, 2019
f3ac0e9
replaced BuildServerList with BuildServerResolver
arturcic Oct 21, 2019
26480d7
moved initialization to CoreModule
arturcic Oct 21, 2019
923f91d
applied code review changes
arturcic Oct 22, 2019
dd892d5
using c#8 using declarations
arturcic Oct 22, 2019
dbac722
code cleanup for GitVersionComputer & GitPrepare
arturcic Oct 22, 2019
df2f486
code cleanup for GitPrepare
arturcic Oct 22, 2019
d7d0dc5
moved the semanticversion classes to folder, made IGitVersionCache DI
arturcic Oct 22, 2019
ec1639e
applied code review changes
arturcic Oct 23, 2019
fb2566f
moving to DI GitVersionFinder, VariableProvider and MetaDataCalculator
arturcic Oct 23, 2019
8e0c12d
moving to DI ConfigurationProvider, GitPreparer
arturcic Oct 23, 2019
d040f41
made GitversionTask DI aware
arturcic Oct 23, 2019
ce1e815
migrate to DI IBaseVersionCalculator
arturcic Oct 23, 2019
9dcce02
migrate to DI NextVersionCalculator
arturcic Oct 23, 2019
901cccc
code cleanup
arturcic Oct 23, 2019
5958435
applied code review changes
arturcic Oct 24, 2019
82a8e33
made GitversionTask DI aware, added GitVersionTaskExecutor
arturcic Oct 24, 2019
433a597
ConfigurationProvider cleanup
arturcic Oct 24, 2019
d572cc7
moving to DI MainlineVersionCalculator
arturcic Oct 24, 2019
dff4e62
using c#8 switch expressions
arturcic Oct 24, 2019
b394a93
moving to DI ConfigInit
arturcic Oct 24, 2019
b243b4d
ConfigInitSteps, made constructor with the same parameters
arturcic Oct 24, 2019
cd1afb1
moving to DI ConfigInit (2), added IConfigInitStepFactory
arturcic Oct 24, 2019
a22fb34
added "?? throw new ArgumentNullException(nameof({field}))" to the i…
arturcic Oct 24, 2019
405cdb3
fix GitPrepare injection
arturcic Oct 24, 2019
ba517dd
moved ConfigInit registration from CoreModule
arturcic Oct 24, 2019
70cb999
introduced ConfigFileLocatorFactory
arturcic Oct 24, 2019
98eebe6
adjusted field names, removed underscore
arturcic Oct 25, 2019
2684c41
code review adjustments
arturcic Oct 25, 2019
7ef3499
code review adjustments
arturcic Oct 25, 2019
02074ed
Moved the `GitVersionTask` and `GitVersionTask.MsBuild` under `GitVer…
arturcic Oct 25, 2019
83ed431
+semver: minor code review adjustments
arturcic Oct 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review adjustments
  • Loading branch information
arturcic committed Oct 25, 2019
commit 7ef3499513931992be479fe0f2c63cb0964a4e23
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using GitVersion.Helpers;
using NUnit.Framework;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.Extensions
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore.Tests/GitRepoMetadataProviderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
using GitVersionCore.Tests.IntegrationTests;
using NUnit.Framework;
using Shouldly;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersionCore.Tests
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore.Tests/GitToolsTestingExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
using GitVersion.OutputVariables;
using LibGit2Sharp;
using Shouldly;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.VersionCalculation;
using GitVersionCore.Tests.VersionCalculation;
using Microsoft.Extensions.Options;
using GitVersion.Extensions;

namespace GitVersionCore.Tests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using GitTools.Testing;
using NUnit.Framework;
using Shouldly;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.IntegrationTests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
using GitTools.Testing;
using GitVersion;
using GitVersion.Configuration;
using GitVersion.Helpers;
using GitVersion.VersioningModes;
using LibGit2Sharp;
using NUnit.Framework;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.IntegrationTests
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using GitTools.Testing;
using LibGit2Sharp;
using NUnit.Framework;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.IntegrationTests
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
using LibGit2Sharp;
using NUnit.Framework;
using Shouldly;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.VersionCalculation
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
using LibGit2Sharp;
using NUnit.Framework;
using Shouldly;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion;
using GitVersion.Extensions;

namespace GitVersionCore.Tests.VersionCalculation
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/BuildServers/AzurePipelines.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
using System.Linq;
using System.Text.RegularExpressions;
using GitVersion.OutputVariables;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion.BuildServers
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
using GitVersion.Helpers;
using GitVersion.Logging;
using LibGit2Sharp;
using GitVersion.Extensions;

namespace GitVersion.Configuration
{
Expand Down
5 changes: 2 additions & 3 deletions src/GitVersionCore/Configuration/Config.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
using GitVersion.VersioningModes;
using YamlDotNet.Serialization;
using GitVersion.Extensions;
using System.IO;
using System.Text;

namespace GitVersion.Configuration
{
using System.IO;
using System.Text;

public class Config
{
private readonly Dictionary<string, BranchConfig> branches = new Dictionary<string, BranchConfig>();
Expand Down
5 changes: 2 additions & 3 deletions src/GitVersionCore/Configuration/ConfigExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
using System.Linq;
using GitVersion.Extensions;
using GitVersion.VersioningModes;
using System;
using System.Text.RegularExpressions;

namespace GitVersion.Configuration
{
using System;
using System.Text.RegularExpressions;

public static class ConfigExtensions
{
public static void Reset(this Config config)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using System.Collections.Generic;

namespace GitVersion.Helpers
namespace GitVersion.Extensions
{
public static class EnumerableExtensions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using GitVersion.Helpers;
using LibGit2Sharp;

namespace GitVersion.Helpers
namespace GitVersion.Extensions
{
public static class LibGitExtensions
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System.IO;

namespace GitVersion.Helpers
namespace GitVersion.Extensions
{
public static class ReadEmbeddedResourceExtensions
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
using System.Text;
using System.Text.RegularExpressions;

namespace GitVersion.Helpers
namespace GitVersion.Extensions
{
public static class StringExtensions
{
Expand Down
1 change: 0 additions & 1 deletion src/GitVersionCore/Extensions/TemplateManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using GitVersion.Helpers;

namespace GitVersion.Extensions
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/GitRepoMetadataProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
using System.Linq;
using System.Text.RegularExpressions;
using GitVersion.Configuration;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/GitVersionContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
using System;
using System.Linq;
using GitVersion.Configuration;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/GitVersionFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
using System.IO;
using GitVersion.Exceptions;
using GitVersion.VersionCalculation;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion
{
Expand Down
1 change: 1 addition & 0 deletions src/GitVersionCore/Helpers/GitRepositoryHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using GitVersion.Exceptions;
using GitVersion.Logging;
using LibGit2Sharp;
using GitVersion.Extensions;

namespace GitVersion.Helpers
{
Expand Down
5 changes: 2 additions & 3 deletions src/GitVersionCore/IncrementStrategyFinder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
using System.Text.RegularExpressions;
using GitVersion.VersionCalculation.BaseVersionCalculators;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Configuration;
using GitVersion.Extensions;

namespace GitVersion
{
using GitVersion.Configuration;

public enum CommitMessageIncrementMode
{
Enabled,
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/OutputFormatters/JsonOutputFormatter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using System.Linq;
using System.Text;
using GitVersion.OutputVariables;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersion.OutputFormatters
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
using System.Linq;
using System.Text.RegularExpressions;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Configuration;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation.BaseVersionCalculators
{
using GitVersion.Configuration;

/// <summary>
/// Version is extracted from older commits's merge messages.
/// BaseVersionSource is the commit where the message was found.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation.BaseVersionCalculators
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
using GitVersion.Helpers;
using LibGit2Sharp;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation.BaseVersionCalculators
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
using System;
using System.Collections.Generic;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Configuration;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation.BaseVersionCalculators
{
using GitVersion.Configuration;

/// <summary>
/// Version is extracted from the name of the branch.
/// BaseVersionSource is the commit where the branch was branched from its parent.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Configuration;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation
{
using GitVersion.Configuration;

internal class MainlineVersionCalculator : IMainlineVersionCalculator
{
private readonly IMetaDataCalculator metaDataCalculator;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Linq;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
using GitVersion.VersionCalculation.BaseVersionCalculators;
using GitVersion.VersioningModes;
using GitVersion.Configuration;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.Extensions;

namespace GitVersion.VersionCalculation
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionCore/VersionFilters/MinDateVersionFilter.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using System;
using GitVersion.VersionCalculation.BaseVersionCalculators;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersion.VersionFilters
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Collections.Generic;
using System.Linq;
using LibGit2Sharp;
using GitVersion.Helpers;
using GitVersion.Extensions;

namespace GitVersion.VersioningModes
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionExe/ArgumentParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
using System.Linq;
using GitVersion.Configuration;
using GitVersion.Exceptions;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.OutputVariables;
using GitVersion.OutputFormatters;
using GitVersion.Extensions;

namespace GitVersion
{
Expand Down
2 changes: 1 addition & 1 deletion src/GitVersionExe/GitVersionExecutor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
using System.Reflection;
using GitVersion.Configuration;
using GitVersion.Exceptions;
using GitVersion.Helpers;
using GitVersion.Logging;
using GitVersion.OutputFormatters;
using GitVersion.Extensions;

namespace GitVersion
{
Expand Down