added "?? throw new ArgumentNullException(nameof({field}))" to the in…

…jected arguments

src/GitVersionCore/Cache/GitVersionCache.cs

@@ -16,8 +16,8 @@ public class GitVersionCache : IGitVersionCache
 
         public GitVersionCache(IFileSystem fileSystem, ILog log)
         {
-            this.fileSystem = fileSystem;
-            this.log = log;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
         }
 
         public void WriteVariablesToDiskCache(IGitPreparer gitPreparer, GitVersionCacheKey cacheKey, VersionVariables variablesFromCache)

src/GitVersionCore/Configuration/BranchConfigurationCalculator.cs

@@ -16,7 +16,7 @@ public class BranchConfigurationCalculator : IBranchConfigurationCalculator
 
         public BranchConfigurationCalculator(ILog log, GitVersionContext context)
         {
-            this.log = log;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
             this.context = context;
         }
 

src/GitVersionCore/Configuration/ConfigFileLocator.cs

@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using GitVersion.Logging;
 
@@ -10,8 +11,8 @@ public abstract class ConfigFileLocator : IConfigFileLocator
 
         protected ConfigFileLocator(IFileSystem fileSystem, ILog log)
         {
-            FileSystem = fileSystem;
-            Log = log;
+            FileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            Log = log ?? throw new ArgumentNullException(nameof(log));
         }
 
         public abstract bool HasConfigFileAt(string workingDirectory);

src/GitVersionCore/Configuration/ConfigurationProvider.cs

@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using System.Text;
 using GitVersion.Configuration.Init.Wizard;
@@ -15,11 +16,11 @@ public class ConfigurationProvider : IConfigurationProvider
 
         public ConfigurationProvider(IFileSystem fileSystem, ILog log, IConfigFileLocator configFileLocator, IGitPreparer gitPreparer, IConfigInitWizard configInitWizard)
         {
-            this.fileSystem = fileSystem;
-            this.log = log;
-            this.configFileLocator = configFileLocator;
-            this.gitPreparer = gitPreparer;
-            this.configInitWizard = configInitWizard;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.configFileLocator = configFileLocator ?? throw new ArgumentNullException(nameof(configFileLocator));
+            this.gitPreparer = gitPreparer ?? throw new ArgumentNullException(nameof(gitPreparer));
+            this.configInitWizard = configInitWizard ?? throw new ArgumentNullException(nameof(this.configInitWizard));
         }
 
         public Config Provide(bool applyDefaults = true, Config overrideConfig = null)

src/GitVersionCore/Configuration/Init/Wizard/ConfigInitStepFactory.cs

@@ -13,7 +13,7 @@ public ConfigInitStepFactory()
 
         public ConfigInitStepFactory(IServiceProvider sp)
         {
-            this.sp = sp;
+            this.sp = sp ?? throw new ArgumentNullException(nameof(sp));
         }
 
         public T CreateStep<T>() => sp.GetService<T>();

src/GitVersionCore/Configuration/Init/Wizard/ConfigInitWizard.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 
 namespace GitVersion.Configuration.Init.Wizard
@@ -9,8 +10,8 @@ public class ConfigInitWizard : IConfigInitWizard
 
         public ConfigInitWizard(IConsole console, IConfigInitStepFactory stepFactory)
         {
-            this.console = console;
-            this.stepFactory = stepFactory;
+            this.console = console ?? throw new ArgumentNullException(nameof(console));
+            this.stepFactory = stepFactory ?? throw new ArgumentNullException(nameof(stepFactory));
         }
 
         public Config Run(Config config, string workingDirectory)

src/GitVersionCore/Configuration/Init/Wizard/ConfigInitWizardStep.cs

@@ -13,10 +13,10 @@ public abstract class ConfigInitWizardStep
 
         protected ConfigInitWizardStep(IConsole console, IFileSystem fileSystem, ILog log, IConfigInitStepFactory stepFactory)
         {
-            Console = console;
-            FileSystem = fileSystem;
-            Log = log;
-            StepFactory = stepFactory;
+            Console = console ?? throw new ArgumentNullException(nameof(console));
+            FileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            Log = log ?? throw new ArgumentNullException(nameof(log));
+            StepFactory = stepFactory ?? throw new ArgumentNullException(nameof(stepFactory));
         }
 
         public bool Apply(Queue<ConfigInitWizardStep> steps, Config config, string workingDirectory)

src/GitVersionCore/Extensions/WixVersionFileUpdater.cs

@@ -18,8 +18,8 @@ public class WixVersionFileUpdater : IDisposable
         public WixVersionFileUpdater(string workingDirectory, VersionVariables variables, IFileSystem fileSystem, ILog log)
         {
             this.variables = variables;
-            this.fileSystem = fileSystem;
-            this.log = log;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
             this.WixVersionFile = Path.Combine(workingDirectory, WIX_VERSION_FILE);
         }
 

src/GitVersionCore/GitPreparer.cs

@@ -19,7 +19,7 @@ public class GitPreparer : IGitPreparer
 
         public GitPreparer(ILog log, Arguments arguments)
         {
-            this.log = log;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
 
             TargetUrl = arguments.TargetUrl;
             WorkingDirectory = arguments.TargetPath.TrimEnd('/', '\\');

src/GitVersionCore/GitVersionCalculator.cs

@@ -25,15 +25,15 @@ public GitVersionCalculator(IFileSystem fileSystem, ILog log, IConfigFileLocator
             IBuildServerResolver buildServerResolver, IGitVersionCache gitVersionCache,
             IGitVersionFinder gitVersionFinder, IGitPreparer gitPreparer, IVariableProvider variableProvider, IOptions<Arguments> options)
         {
-            this.fileSystem = fileSystem;
-            this.log = log;
-            this.configFileLocator = configFileLocator;
-            this.configurationProvider = configurationProvider;
-            this.buildServerResolver = buildServerResolver;
-            this.gitVersionCache = gitVersionCache;
-            this.gitVersionFinder = gitVersionFinder;
-            this.gitPreparer = gitPreparer;
-            this.variableProvider = variableProvider;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.configFileLocator = configFileLocator ?? throw new ArgumentNullException(nameof(configFileLocator));
+            this.configurationProvider = configurationProvider ?? throw new ArgumentNullException(nameof(configurationProvider));
+            this.buildServerResolver = buildServerResolver ?? throw new ArgumentNullException(nameof(buildServerResolver));
+            this.gitVersionCache = gitVersionCache ?? throw new ArgumentNullException(nameof(gitVersionCache));
+            this.gitVersionFinder = gitVersionFinder ?? throw new ArgumentNullException(nameof(gitVersionFinder));
+            this.gitPreparer = gitPreparer ?? throw new ArgumentNullException(nameof(gitPreparer));
+            this.variableProvider = variableProvider ?? throw new ArgumentNullException(nameof(variableProvider));
             this.arguments = options.Value;
         }
 

src/GitVersionCore/GitVersionFinder.cs

@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using GitVersion.Exceptions;
 using GitVersion.VersionCalculation;
@@ -14,8 +15,8 @@ public class GitVersionFinder : IGitVersionFinder
 
         public GitVersionFinder(ILog log, INextVersionCalculator nextVersionCalculator)
         {
-            this.log = log;
-            this.nextVersionCalculator = nextVersionCalculator;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.nextVersionCalculator = nextVersionCalculator ?? throw new ArgumentNullException(nameof(nextVersionCalculator));
         }
 
         public SemanticVersion FindVersion(GitVersionContext context)

src/GitVersionCore/IncrementStrategyFinder.cs

@@ -91,8 +91,6 @@ public static class IncrementStrategyFinder
             return null;
         }
 
-
-
         private static IEnumerable<Commit> GetIntermediateCommits(IRepository repo, Commit baseCommit, Commit headCommit)
         {
             if (baseCommit == null) yield break;
@@ -131,7 +129,6 @@ private static IEnumerable<Commit> GetIntermediateCommits(IRepository repo, Comm
             return version;
         }
 
-
         private static VersionField? FindIncrementFromMessage(string message, string majorRegex, string minorRegex, string patchRegex, string noneRegex)
         {
             if(IsMatch(message, majorRegex)) return VersionField.Major;

src/GitVersionCore/OutputVariables/VariableProvider.cs

@@ -15,7 +15,7 @@ public class VariableProvider : IVariableProvider
 
         public VariableProvider(INextVersionCalculator nextVersionCalculator)
         {
-            this.nextVersionCalculator = nextVersionCalculator;
+            this.nextVersionCalculator = nextVersionCalculator ?? throw new ArgumentNullException(nameof(nextVersionCalculator));
         }
 
         public VersionVariables GetVariablesFor(SemanticVersion semanticVersion, EffectiveConfiguration config, bool isCurrentCommitTagged)

src/GitVersionCore/VersionCalculation/BaseVersionCalculator.cs

@@ -15,7 +15,7 @@ public class BaseVersionCalculator : IBaseVersionCalculator
 
         public BaseVersionCalculator(ILog log, IEnumerable<IVersionStrategy> strategies)
         {
-            this.log = log;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
             this.strategies = strategies?.ToArray() ?? Array.Empty<IVersionStrategy>();
         }
 

src/GitVersionCore/VersionCalculation/MainlineVersionCalculator.cs

@@ -17,8 +17,8 @@ internal class MainlineVersionCalculator : IMainlineVersionCalculator
 
         public MainlineVersionCalculator(ILog log, IMetaDataCalculator metaDataCalculator)
         {
-            this.metaDataCalculator = metaDataCalculator;
-            this.log = log;
+            this.metaDataCalculator = metaDataCalculator ?? throw new ArgumentNullException(nameof(metaDataCalculator));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
         }
 
         public SemanticVersion FindMainlineModeVersion(BaseVersion baseVersion, GitVersionContext context)

src/GitVersionCore/VersionCalculation/NextVersionCalculator.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using System.Text.RegularExpressions;
 using GitVersion.VersionCalculation.BaseVersionCalculators;
@@ -18,11 +19,11 @@ public class NextVersionCalculator : INextVersionCalculator
 
         public NextVersionCalculator(ILog log, IMetaDataCalculator metaDataCalculator, IBaseVersionCalculator baseVersionCalculator, IMainlineVersionCalculator mainlineVersionCalculator)
         {
-            this.log = log;
-            this.metaDataCalculator = metaDataCalculator;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.metaDataCalculator = metaDataCalculator ?? throw new ArgumentNullException(nameof(metaDataCalculator));
 
-            this.baseVersionCalculator = baseVersionCalculator;
-            this.mainlineVersionCalculator = mainlineVersionCalculator;
+            this.baseVersionCalculator = baseVersionCalculator ?? throw new ArgumentNullException(nameof(baseVersionCalculator));
+            this.mainlineVersionCalculator = mainlineVersionCalculator ?? throw new ArgumentNullException(nameof(mainlineVersionCalculator));
         }
 
         public SemanticVersion FindVersion(GitVersionContext context)

src/GitVersionExe/ExecCommand.cs

@@ -26,10 +26,10 @@ public class ExecCommand : IExecCommand
 
         public ExecCommand(IFileSystem fileSystem, IBuildServerResolver buildServerResolver, ILog log, IGitVersionCalculator gitVersionCalculator, IOptions<Arguments> arguments)
         {
-            this.fileSystem = fileSystem;
-            this.buildServerResolver = buildServerResolver;
-            this.log = log;
-            this.gitVersionCalculator = gitVersionCalculator;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.buildServerResolver = buildServerResolver ?? throw new ArgumentNullException(nameof(buildServerResolver));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.gitVersionCalculator = gitVersionCalculator ?? throw new ArgumentNullException(nameof(gitVersionCalculator));
             this.arguments = arguments.Value;
         }
 

src/GitVersionExe/GitVersionApp.cs

@@ -16,8 +16,8 @@ internal class GitVersionApp : IHostedService
         public GitVersionApp(IHostApplicationLifetime applicationLifetime, IGitVersionExecutor gitVersionExecutor, ILog log, IOptions<Arguments> options)
         {
             this.arguments = options.Value;
-            this.applicationLifetime = applicationLifetime;
-            this.gitVersionExecutor = gitVersionExecutor;
+            this.applicationLifetime = applicationLifetime ?? throw new ArgumentNullException(nameof(applicationLifetime));
+            this.gitVersionExecutor = gitVersionExecutor ?? throw new ArgumentNullException(nameof(gitVersionExecutor));
 
             log.Verbosity = arguments.Verbosity;
         }

src/GitVersionExe/GitVersionExecutor.cs

@@ -22,13 +22,13 @@ public class GitVersionExecutor : IGitVersionExecutor
         public GitVersionExecutor(ILog log, IConfigFileLocator configFileLocator, IVersionWriter versionWriter, IHelpWriter helpWriter,
             IExecCommand execCommand, IConfigurationProvider configurationProvider, IBuildServerResolver buildServerResolver)
         {
-            this.log = log;
-            this.configFileLocator = configFileLocator;
-            this.versionWriter = versionWriter;
-            this.helpWriter = helpWriter;
-            this.execCommand = execCommand;
-            this.configurationProvider = configurationProvider;
-            this.buildServerResolver = buildServerResolver;
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.configFileLocator = configFileLocator ?? throw new ArgumentNullException(nameof(configFileLocator));
+            this.versionWriter = versionWriter ?? throw new ArgumentNullException(nameof(versionWriter));
+            this.helpWriter = helpWriter ?? throw new ArgumentNullException(nameof(helpWriter));
+            this.execCommand = execCommand ?? throw new ArgumentNullException(nameof(execCommand));
+            this.configurationProvider = configurationProvider ?? throw new ArgumentNullException(nameof(configFileLocator));
+            this.buildServerResolver = buildServerResolver ?? throw new ArgumentNullException(nameof(buildServerResolver));
         }
 
         public int Execute(Arguments arguments)

src/GitVersionExe/HelpWriter.cs

@@ -9,7 +9,7 @@ public class HelpWriter : IHelpWriter
 
         public HelpWriter(IVersionWriter versionWriter)
         {
-            this.versionWriter = versionWriter;
+            this.versionWriter = versionWriter ?? throw new ArgumentNullException(nameof(versionWriter));
         }
 
         public void Write()

src/GitVersionTask/GitVersionTaskExecutor.cs

@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using GitVersion;
 using GitVersion.Extensions.GitVersionInformationResources;
@@ -17,10 +18,10 @@ public class GitVersionTaskExecutor : IGitVersionTaskExecutor
 
         public GitVersionTaskExecutor(IFileSystem fileSystem, ILog log, IBuildServerResolver buildServerResolver, IGitVersionCalculator gitVersionCalculator)
         {
-            this.fileSystem = fileSystem;
-            this.log = log;
-            this.buildServerResolver = buildServerResolver;
-            this.gitVersionCalculator = gitVersionCalculator;
+            this.fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
+            this.log = log ?? throw new ArgumentNullException(nameof(log));
+            this.buildServerResolver = buildServerResolver ?? throw new ArgumentNullException(nameof(buildServerResolver));
+            this.gitVersionCalculator = gitVersionCalculator ?? throw new ArgumentNullException(nameof(gitVersionCalculator));
         }
 
         public void GetVersion(GetVersion task)