-
Notifications
You must be signed in to change notification settings - Fork 9.7k
core(tap-targets): don't exclude visible position absolute elements from audit #7778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
728c003
Filter pos absolute elements using elementFromPoint
mattzeunert 90404ff
Restore formatting
mattzeunert d3a9a8d
Revert "Restore formatting"
mattzeunert 06a624a
Restore formatting
mattzeunert 659fa88
scroll window instead of document
mattzeunert 0f8e2df
Make disable point-events !imporant
mattzeunert 233ee73
Position absolute wrapper for smoke test failure
mattzeunert d9d40bf
Fix lint
mattzeunert 76cc42f
Fix code cov tests
mattzeunert c2767c3
Fix code cov
mattzeunert 993dd77
Go further up down when checking if within scrollable area
mattzeunert a6d9932
Always use fn.toString instead of fnString for rect helpers
mattzeunert 463622c
Code style tweaks
mattzeunert 7f38635
Scroll to target position instead of using while loop
mattzeunert 4b9f808
while loop -> for of loop
mattzeunert 31d8251
Fix exception
mattzeunert 8622bf4
Don't make unreasonable scrollY check
mattzeunert cb4835f
Comment
mattzeunert 7c1ed2d
Artifact assertions
mattzeunert 1c16558
Revert "Artifact assertions"
mattzeunert 97fe391
Wrap expectations in LHR
mattzeunert 88d5a83
Update smoke test logic to support lhr/audit and artifact assertions
mattzeunert b499b52
Move artifacts to .tmp
mattzeunert e91d5cd
Make errorCode top level
mattzeunert 810b37e
Remove empty line
mattzeunert ecc7091
Fix types and actually assert stuff
mattzeunert bc81d78
Style tweaks
mattzeunert fc85de0
Merge comparisons/assertions
mattzeunert ab754df
Add smoke test for overflow hidden client rects
mattzeunert 8a41fef
Merge branch 'master' into tap-target-position-absolute
mattzeunert cc44890
Merge branch 'artifacts-assertions' into tap-target-position-absolute
mattzeunert 3593edf
Merge branch 'master' into tap-target-position-absolute
mattzeunert abaf722
typo
mattzeunert 9dece7f
Check each client rect, remove overflow container check
mattzeunert 32a41ac
Remove save gatherer to file
mattzeunert 4d626a4
More detailed smoke test assertions
mattzeunert ccf9557
Add failing test case for pos absolute child causing overlap
mattzeunert d69910a
Remove extra type assertion
mattzeunert af0fdde
Remove filterClientRectsWithinAncestorsVisibleScrollArea
mattzeunert 6e2f54e
Move disableFixedAndStickyElementPointerEvents call
mattzeunert 7183ac6
Fix position sticky test case
mattzeunert 9353561
Merge branch 'master' into tap-target-position-absolute
mattzeunert 6d02ea5
Text tweak
mattzeunert f4a9ee4
Use textContent instead of innerHTML
brendankenny 8fd5e2d
No need for Array.from
brendankenny b5a86d6
Spelling
brendankenny f20fc20
Make tap targets in SEO smoke test more explicit
mattzeunert befe66e
Merge branch 'tap-target-position-absolute' of https://github.com/Goo…
mattzeunert fda7c9e
doc
mattzeunert aafa240
Fix smoke coverage
mattzeunert 5e3c2f8
Merge branch 'master' into tap-target-position-absolute
brendankenny 6689f0d
more
brendankenny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Comment
- Loading branch information
commit cb4835f870f985024e9f05c8d895100a471a7149
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.