Skip to content

core(tap-targets): don't exclude visible position absolute elements from audit #7778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhulce merged 52 commits into from
May 25, 2019
Merged

core(tap-targets): don't exclude visible position absolute elements from audit #7778

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
728c003
Filter pos absolute elements using elementFromPoint
mattzeunert Mar 28, 2019
90404ff
Restore formatting
mattzeunert Mar 28, 2019
d3a9a8d
Revert "Restore formatting"
mattzeunert Mar 28, 2019
06a624a
Restore formatting
mattzeunert Mar 28, 2019
659fa88
scroll window instead of document
mattzeunert Apr 2, 2019
0f8e2df
Make disable point-events !imporant
mattzeunert Apr 3, 2019
233ee73
Position absolute wrapper for smoke test failure
mattzeunert Apr 3, 2019
d9d40bf
Fix lint
mattzeunert Apr 3, 2019
76cc42f
Fix code cov tests
mattzeunert Apr 3, 2019
c2767c3
Fix code cov
mattzeunert Apr 3, 2019
993dd77
Go further up down when checking if within scrollable area
mattzeunert Apr 3, 2019
a6d9932
Always use fn.toString instead of fnString for rect helpers
mattzeunert Apr 3, 2019
463622c
Code style tweaks
mattzeunert Apr 3, 2019
7f38635
Scroll to target position instead of using while loop
mattzeunert Apr 3, 2019
4b9f808
while loop -> for of loop
mattzeunert Apr 3, 2019
31d8251
Fix exception
mattzeunert Apr 3, 2019
8622bf4
Don't make unreasonable scrollY check
mattzeunert Apr 3, 2019
cb4835f
Comment
mattzeunert Apr 7, 2019
7c1ed2d
Artifact assertions
mattzeunert Apr 7, 2019
1c16558
Revert "Artifact assertions"
mattzeunert Apr 7, 2019
97fe391
Wrap expectations in LHR
mattzeunert Apr 7, 2019
88d5a83
Update smoke test logic to support lhr/audit and artifact assertions
mattzeunert Apr 7, 2019
b499b52
Move artifacts to .tmp
mattzeunert Apr 8, 2019
e91d5cd
Make errorCode top level
mattzeunert Apr 8, 2019
810b37e
Remove empty line
mattzeunert Apr 8, 2019
ecc7091
Fix types and actually assert stuff
mattzeunert Apr 8, 2019
bc81d78
Style tweaks
mattzeunert Apr 8, 2019
fc85de0
Merge comparisons/assertions
mattzeunert Apr 8, 2019
ab754df
Add smoke test for overflow hidden client rects
mattzeunert Apr 9, 2019
8a41fef
Merge branch 'master' into tap-target-position-absolute
mattzeunert Apr 9, 2019
cc44890
Merge branch 'artifacts-assertions' into tap-target-position-absolute
mattzeunert Apr 9, 2019
3593edf
Merge branch 'master' into tap-target-position-absolute
mattzeunert Apr 16, 2019
abaf722
typo
mattzeunert Apr 16, 2019
9dece7f
Check each client rect, remove overflow container check
mattzeunert Apr 17, 2019
32a41ac
Remove save gatherer to file
mattzeunert Apr 17, 2019
4d626a4
More detailed smoke test assertions
mattzeunert Apr 17, 2019
ccf9557
Add failing test case for pos absolute child causing overlap
mattzeunert Apr 17, 2019
d69910a
Remove extra type assertion
mattzeunert Apr 17, 2019
af0fdde
Remove filterClientRectsWithinAncestorsVisibleScrollArea
mattzeunert Apr 17, 2019
6e2f54e
Move disableFixedAndStickyElementPointerEvents call
mattzeunert Apr 17, 2019
7183ac6
Fix position sticky test case
mattzeunert Apr 17, 2019
9353561
Merge branch 'master' into tap-target-position-absolute
mattzeunert Apr 17, 2019
6d02ea5
Text tweak
mattzeunert Apr 17, 2019
f4a9ee4
Use textContent instead of innerHTML
brendankenny Apr 21, 2019
8fd5e2d
No need for Array.from
brendankenny Apr 21, 2019
b5a86d6
Spelling
brendankenny Apr 21, 2019
f20fc20
Make tap targets in SEO smoke test more explicit
mattzeunert Apr 21, 2019
befe66e
Merge branch 'tap-target-position-absolute' of https://github.com/Goo…
mattzeunert Apr 21, 2019
fda7c9e
doc
mattzeunert Apr 21, 2019
aafa240
Fix smoke coverage
mattzeunert Apr 25, 2019
5e3c2f8
Merge branch 'master' into tap-target-position-absolute
brendankenny May 25, 2019
6689f0d
more
brendankenny May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
414 changes: 208 additions & 206 deletions lighthouse-cli/test/smokehouse/a11y/expectations.js
View file
Open in desktop

Large diffs are not rendered by default.

220 changes: 112 additions & 108 deletions lighthouse-cli/test/smokehouse/byte-efficiency/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,134 +10,138 @@
*/
module.exports = [
{
requestedUrl: 'http://localhost:10200/byte-efficiency/tester.html',
finalUrl: 'http://localhost:10200/byte-efficiency/tester.html',
audits: {
'unminified-css': {
details: {
overallSavingsBytes: '>17000',
items: {
length: 2,
lhr: {
requestedUrl: 'http://localhost:10200/byte-efficiency/tester.html',
finalUrl: 'http://localhost:10200/byte-efficiency/tester.html',
audits: {
'unminified-css': {
details: {
overallSavingsBytes: '>17000',
items: {
length: 2,
},
},
},
},
'unminified-javascript': {
score: '<1',
details: {
overallSavingsBytes: '>45000',
overallSavingsMs: '>500',
items: [
{
url: 'http://localhost:10200/byte-efficiency/script.js',
wastedBytes: '46481 +/- 100',
wastedPercent: '87 +/- 5',
},
{
url: 'inline: \n function unusedFunction() {\n // Un...',
wastedBytes: '6581 +/- 100',
wastedPercent: '99.6 +/- 0.1',
},
{
url: 'inline: \n // Used block #1\n // FILLER DATA JUS...',
wastedBytes: '6559 +/- 100',
wastedPercent: 100,
'unminified-javascript': {
score: '<1',
details: {
overallSavingsBytes: '>45000',
overallSavingsMs: '>500',
items: [
{
url: 'http://localhost:10200/byte-efficiency/script.js',
wastedBytes: '46481 +/- 100',
wastedPercent: '87 +/- 5',
},
{
url: 'inline: \n function unusedFunction() {\n // Un...',
wastedBytes: '6581 +/- 100',
wastedPercent: '99.6 +/- 0.1',
},
{
url: 'inline: \n // Used block #1\n // FILLER DATA JUS...',
wastedBytes: '6559 +/- 100',
wastedPercent: 100,
},
],
},
},
'unused-css-rules': {
details: {
overallSavingsBytes: '>35000',
items: {
length: 2,
},
],
},
},
},
'unused-css-rules': {
details: {
overallSavingsBytes: '>35000',
items: {
length: 2,
'unused-javascript': {
score: '<1',
details: {
overallSavingsBytes: '>=25000',
overallSavingsMs: '>300',
items: {
length: 2,
},
},
},
},
'unused-javascript': {
score: '<1',
details: {
overallSavingsBytes: '>=25000',
overallSavingsMs: '>300',
items: {
length: 2,
'offscreen-images': {
details: {
items: [
{
url: /lighthouse-unoptimized.jpg$/,
}, {
url: /lighthouse-480x320.webp$/,
}, {
url: /lighthouse-480x320.webp\?invisible$/,
}, {
url: /large.svg$/,
},
],
},
},
},
'offscreen-images': {
details: {
items: [
{
url: /lighthouse-unoptimized.jpg$/,
}, {
url: /lighthouse-480x320.webp$/,
}, {
url: /lighthouse-480x320.webp\?invisible$/,
}, {
url: /large.svg$/,
'uses-webp-images': {
details: {
overallSavingsBytes: '>60000',
items: {
length: 4,
},
],
},
},
'uses-webp-images': {
details: {
overallSavingsBytes: '>60000',
items: {
length: 4,
},
},
},
'uses-text-compression': {
score: '<1',
details: {
overallSavingsMs: '>700',
overallSavingsBytes: '>50000',
items: {
length: 2,
'uses-text-compression': {
score: '<1',
details: {
overallSavingsMs: '>700',
overallSavingsBytes: '>50000',
items: {
length: 2,
},
},
},
},
'uses-optimized-images': {
details: {
overallSavingsBytes: '>10000',
items: {
length: 1,
'uses-optimized-images': {
details: {
overallSavingsBytes: '>10000',
items: {
length: 1,
},
},
},
},
'uses-responsive-images': {
displayValue: 'Potential savings of 75\xa0KB',
details: {
overallSavingsBytes: '>75000',
items: [
{wastedPercent: '<60'},
{wastedPercent: '<60'},
{wastedPercent: '<60'},
],
'uses-responsive-images': {
displayValue: 'Potential savings of 75\xa0KB',
details: {
overallSavingsBytes: '>75000',
items: [
{wastedPercent: '<60'},
{wastedPercent: '<60'},
{wastedPercent: '<60'},
],
},
},
},
},
},
{
requestedUrl: 'http://localhost:10200/byte-efficiency/gzip.html',
finalUrl: 'http://localhost:10200/byte-efficiency/gzip.html',
audits: {
'network-requests': {
details: {
items: [
{
url: 'http://localhost:10200/byte-efficiency/gzip.html',
},
{
url: 'http://localhost:10200/byte-efficiency/script.js?gzip=1',
transferSize: 1136,
resourceSize: 52997,
},
{
url: 'http://localhost:10200/byte-efficiency/script.js',
transferSize: 53181,
resourceSize: 52997,
},
],
lhr: {
requestedUrl: 'http://localhost:10200/byte-efficiency/gzip.html',
finalUrl: 'http://localhost:10200/byte-efficiency/gzip.html',
audits: {
'network-requests': {
details: {
items: [
{
url: 'http://localhost:10200/byte-efficiency/gzip.html',
},
{
url: 'http://localhost:10200/byte-efficiency/script.js?gzip=1',
transferSize: 1136,
resourceSize: 52997,
},
{
url: 'http://localhost:10200/byte-efficiency/script.js',
transferSize: 53181,
resourceSize: 52997,
},
],
},
},
},
},
Expand Down
Loading