Skip to content

deps: update to open from opn #9267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brendankenny merged 3 commits into from
Jul 15, 2019
Merged

deps: update to open from opn #9267

brendankenny merged 3 commits into from
Jul 15, 2019

Conversation

@jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Jun 24, 2019

closes #9265

Summary

Switch to open.

Related Issues/PRs

Fixes #9265

patrickhulce
patrickhulce suggested changes Jun 24, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jamesgeorge007! think you could update that reference in docs/readme.md we found too?

@patrickhulce patrickhulce changed the title fix(chore): switch to open deps: update to open from opn Jun 24, 2019
@jamesgeorge007
Update docs
1406ac7 
update reference of opn to open
@patrickhulce
Copy link
Collaborator

patrickhulce commented Jun 24, 2019

Oh no! open's types don't work in our version of typescript 😢 (3.2.2)

image

Seems like they work with 3.4.x which added support for that readonly array operator https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html, so we might have to hold off landing this until we can update.

brendankenny
brendankenny reviewed Jun 24, 2019
View reviewed changes
@patrickhulce
Copy link
Collaborator

patrickhulce commented Jun 28, 2019

We won't be able to continue with this until we migrate the rest of the codebase to typescript 3.4. The types in the latest version of open require features not supported in earlier versions.

@brendankenny brendankenny mentioned this pull request Jul 12, 2019
Merged
@brendankenny
Copy link
Contributor

brendankenny commented Jul 12, 2019

this should be able to land now that #9357 is in, rerunning tests (hopefully it'll work without updating the branch)

brendankenny
brendankenny reviewed Jul 12, 2019
View reviewed changes
brendankenny
brendankenny suggested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good, LGTM when the updated yarn.lock file is included!

@brendankenny brendankenny mentioned this pull request Jul 12, 2019
Merged
@jamesgeorge007
Copy link
Contributor Author

jamesgeorge007 commented Jul 13, 2019

cc @brendankenny @patrickhulce

patrickhulce
patrickhulce approved these changes Jul 13, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brendankenny
brendankenny approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@brendankenny brendankenny merged commit 78a1a8f into GoogleChrome:master Jul 15, 2019
@brendankenny
Copy link
Contributor

brendankenny commented Jul 15, 2019

thanks!

@brendankenny brendankenny mentioned this pull request Jul 17, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulirish paulirish Awaiting requested review from paulirish

2 more reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opn is deprecated, switch to open

5 participants

@jamesgeorge007 @patrickhulce @brendankenny @connorjclark @googlebot