tests(i18n): update canonical locale test for node 12 #9396
Conversation
| // Map of deprecated codes to their canonical version. Depending on the ICU | ||
| // version used to run Lighthouse/this test, these *may* come back as their | ||
| // substitute, not themselves. | ||
| const deprecatedCodes = { |
There was a problem hiding this comment.
based on locales.js.. it looks like there's also these ones:
'bs': 'hr',
'ln': 'fr',
'nb': 'no',
'tl': 'fil',
this list is spelled out concretely somewhere in the CLDR, too
There was a problem hiding this comment.
based on locales.js.. it looks like there's also these ones:
the ICU in Chrome Canary (V8 7.7) and Node 12.6 (V8 7.5) stil have these as canonical locales. The intent of the test was just to double check that if someone asks for one of the locales we have strings for that they'll actually get it, and deprecatedCodes was to handle the awkward time when a locale is deprecated on the bleeding edge but not in our earliest supported Chrome/Node.
Since they aren't deprecated in the latest version of V8/Intl yet, and since the switch to deprecated is a nice trigger to double check our locales here, I think we should leave these out for now
4 participants
Node 12.6 is now calling
'mo'deprecated and gives'ro'as the canonical version for me.mois already an alias ofro, so that seems fine, but the canonical locale test needs to account for this or it will fail.Also:
is-wslchange, missed due to a combo of deps: update to open from opn #9267 and deps: [email protected] #9339 (chrome-launcher moved to2.1.0butopenstill requires1.1.0)