deps: [email protected] #9339
Merged
deps: [email protected] #9339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jul 10, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM
bummer we don't have any tests for it, should we treat this as part of our API?
| let startingUrl; | ||
| let port; | ||
| let enableExtensions; | ||
| let shouldEnableExtensions; |
Collaborator
There was a problem hiding this comment.
seems like these two variables always have the same value, yes?
feels like we could ditch shouldEnableExtensions at this point if it's just the if
Contributor
|
fixes #9279 |
brendankenny
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notable commits:
448a1d48chrome-finder: Add support for MacOS Catalina (Fix MacOS Catalina Regex issue chrome-launcher#149)55b891bbdeps(is-wsl): add support for WSL 2; drop Node 6 (Add WSL 2 support and remove Node 6 support chrome-launcher#152)fixes #9279