upload screenshot to GCS Bucket #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamfweidman
force-pushed
the
take-screenshots
branch
4 times, most recently
from
23dcbd9 to
bfbabc3
Compare
adamfweidman
force-pushed
the
take-screenshots
branch
from
bfbabc3 to
8f1cd51
Compare
nikitajainn-google
approved these changes
Feb 28, 2024
adamfweidman
added a commit
that referenced
this pull request
Feb 28, 2024
adamfweidman
added a commit
that referenced
this pull request
Feb 28, 2024
adamfweidman
added a commit
that referenced
this pull request
Mar 20, 2024
adamfweidman
added a commit
that referenced
this pull request
Apr 19, 2024
* get-cloud-region (#100) Add functionality to synthetics-sdk-api to extract cloud region during GCF execution * stoage proto api (#101) * expose resolveProjectId (#104) * update to capture_condition (#109) * chore(deps): bump ip from 1.1.8 to 1.1.9 (#105) * chore(deps): bump ip from 1.1.8 to 1.1.9 Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Empty-Commit --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Weidman <[email protected]> * add samples tags (#108) * blc-api-integration-def (#102) * resolveProjectId present (#106) * take-screenshots (#107) * rebase-capture-condition (#110) * refactor-integrations (#112) * sanitize strings (#113) * Take and populate screenshot (#114) * screenshots-prop * broken_links.spec working * fix naming * pass-args * response to comments * change default (#118) * update synthetics-sdk-api to point to new npm pkg --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
adamfweidman
added a commit
that referenced
this pull request
Apr 19, 2024
adamfweidman
added a commit
that referenced
this pull request
Apr 19, 2024
* blc-api-integration-def (#102) * resolveProjectId present (#106) * take-screenshots (#107) * rebase-capture-condition (#110) * refactor-integrations (#112) * sanitize strings (#113) * Take and populate screenshot (#114) * screenshots-prop * broken_links.spec working * fix naming * pass-args * response to comments * change default (#118) * update synthetics-sdk-api to point to new npm pkg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mainly introduces the
uploadScreenshotToGCS()function and its helpergetFolderNameFromStorageLocation()both of these functions are tested in the corresponding spec.ts file.uploadScreenshotToGCS will be called within the checkLink function in navigation_func. This function will only be called if the user's screenshotCondition and link status align.
I've additionally added an assertion in an earlier test for code coverage reasons.