feat: Add screenshot storage support to broken link checker #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* screenshots-prop * broken_links.spec working * fix naming * pass-args * response to comments
jdurelli
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now allowing users to choose to capture screenshots of the links that are visited by the broken link checker. These images are uploaded to a user's GCS bucket and later displayed in the synthetic executions UI. Users will be able to specify when they want screenshots captured (always, only when a link fails, never) and whether they want us to create a GCS bucket for them or use an existing one
capture_conditions potential values:
'ALL', 'FAILING', 'NONE'examples:
screenshot_options: {capture_condition: 'FAILING' } // a GCS bucket will be created for youscreenshot_options: {capture_condition: 'ALL', storage_location: 'my-test-bucket' }