Skip to content

feat: Add screenshot storage support to broken link checker #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamfweidman merged 9 commits into from
Apr 19, 2024
Merged

feat: Add screenshot storage support to broken link checker #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dad0dae
blc-api-integration-def (#102)
adamfweidman Feb 20, 2024
a6d82b8
resolveProjectId present (#106)
adamfweidman Feb 23, 2024
36abd54
take-screenshots (#107)
adamfweidman Feb 28, 2024
95f16d9
rebase-capture-condition (#110)
adamfweidman Feb 29, 2024
b1d8579
refactor-integrations (#112)
adamfweidman Mar 8, 2024
61122a2
sanitize strings (#113)
adamfweidman Mar 20, 2024
be99a9f
Take and populate screenshot (#114)
adamfweidman Mar 29, 2024
2b3d943
change default (#118)
adamfweidman Apr 15, 2024
8eb8f42
update synthetics-sdk-api to point to new npm pkg
adamfweidman Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change default (#118)
  • Loading branch information
@adamfweidman
adamfweidman committed Apr 19, 2024
commit 2b3d94302f25cc0e01393093e5234ae1f440c13c
3 changes: 3 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/synthetics-sdk-broken-links/src/options_func.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export function setDefaultOptions(
per_link_options: {},
total_synthetic_timeout_millis: 60000,
screenshot_options: {
capture_condition: ApiCaptureCondition.FAILING,
capture_condition: ApiCaptureCondition.NONE,
storage_location: '',
},
};
Expand Down
4 changes: 2 additions & 2 deletions packages/synthetics-sdk-broken-links/test/unit/navigation_func.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ describe('GCM Synthetics Broken Links Navigation Functionality', async () => {
link_start_time: 'NA',
link_end_time: 'NA',
is_origin: false,
screenshot_output: successfulScreenshotOuput,
screenshot_output: emptyScreenshotOutput,
};

expect(synLinkResult)
Expand Down Expand Up @@ -326,7 +326,7 @@ describe('GCM Synthetics Broken Links Navigation Functionality', async () => {
link_start_time: 'NA',
link_end_time: 'NA',
is_origin: false,
screenshot_output: successfulScreenshotOuput,
screenshot_output: emptyScreenshotOutput,
};

expect(synLinkResult)
Expand Down
5 changes: 5 additions & 0 deletions packages/synthetics-sdk-broken-links/test/unit/options_func.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { expect } from 'chai';
// Internal Project Files
import {
BrokenLinksResultV1_BrokenLinkCheckerOptions_LinkOrder,
BrokenLinksResultV1_BrokenLinkCheckerOptions_ScreenshotOptions_CaptureCondition as ApiCaptureCondition,
ResponseStatusCode,
ResponseStatusCode_StatusClass,
} from '@google-cloud/synthetics-sdk-api';
Expand Down Expand Up @@ -95,6 +96,10 @@ describe('GCM Synthetics Broken Links options_func suite testing', () => {
},
};
expect(options.per_link_options).to.deep.equal(link_options);

expect(options.screenshot_options?.capture_condition).to.equal(
ApiCaptureCondition.NONE
);
});

describe('validateInputOptions', () => {
Expand Down