Custom relay state default #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djangosaml2/views.py
Outdated
|
|
||
| # redirect the user to the view where he came from | ||
| relay_state = request.POST.get('RelayState', '/') | ||
| default_relay_state = get_custom_setting('ACS_DEFAULT_REDIRECT_URL', '/') |
Collaborator
There was a problem hiding this comment.
I'm OK with this, but how about changing the '/' default to settings.LOGIN_REDIRECT_URL?
Contributor
Author
There was a problem hiding this comment.
Sounds good. It would be consistent with the lines below.
Collaborator
|
Thank you, I'll gladly merge this! |
knaperek
pushed a commit
that referenced
this pull request
Feb 5, 2020
peppelinux
pushed a commit
that referenced
this pull request
May 1, 2023
* split authenticate into separate overridable function * cleaner exception * basic unit test * remove new test * space to revert change * return the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a custom setting to redirect ACS after a successful authentication when the IdP does not specify a RelayState attribute.