Skip to content

Custom relay state default #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 3 commits into from
Mar 18, 2016
Merged

Custom relay state default #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a06ac89
added a setting for default redirection after successful authentication
ganiserb Mar 16, 2016
a6dc168
updated docs for the new setting
ganiserb Mar 16, 2016
e732091
updated handling of default RelayState attribute
ganiserb Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,13 @@ can set in the settings.py file::

This setting is True by default.

ACS_DEFAULT_REDIRECT_URL = reverse_lazy('some_url_name')

This setting lets you specify a URL for redirection after a successful
authentication. Particularly useful when you only plan to use
IdP initiated login and the IdP does not have a configured RelayState
parameter. The default is ``/``.

The other thing you will probably want to configure is the mapping of
SAML2 user attributes to Django user attributes. By default only the
User.username attribute is mapped but you can add more attributes or
Expand Down
3 changes: 2 additions & 1 deletion djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ def assertion_consumer_service(request,
post_authenticated.send_robust(sender=user, session_info=session_info)

# redirect the user to the view where he came from
relay_state = request.POST.get('RelayState', '/')
default_relay_state = get_custom_setting('ACS_DEFAULT_REDIRECT_URL', '/')
Copy link
Collaborator

@knaperek knaperek Mar 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but how about changing the '/' default to settings.LOGIN_REDIRECT_URL?

Copy link
Contributor Author

@ganiserb ganiserb Mar 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. It would be consistent with the lines below.

relay_state = request.POST.get('RelayState', default_relay_state)
if not relay_state:
logger.warning('The RelayState parameter exists but is empty')
relay_state = settings.LOGIN_REDIRECT_URL
Expand Down