Skip to content

Better error message around us choosing what binding to use #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 8 commits into from
Apr 14, 2017
Merged

Better error message around us choosing what binding to use #51

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
273e545
Better error message on unsupported bindings
liquidpele Apr 10, 2017
7cf6f79
Use a proper Exception and not NotImplemented
liquidpele Apr 10, 2017
d515d6c
Merge remote-tracking branch 'upstream/master' into liquidpele-patch-2
Apr 10, 2017
675dc38
Intelligently pick SSO binding based on IDP metadata instead of only …
Apr 12, 2017
4c259f8
Use logger variable arguments
Apr 12, 2017
bd44fc0
Fix unit tests by passing conf we already had, not sure why get_confi…
Apr 12, 2017
ce05d8f
python 3.5+ apparnelty returns a dict_keys object from .keys() so acc…
Apr 12, 2017
9abd86f
Merge remote-tracking branch 'upstream/master' into liquidpele-patch-2
Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Better error message on unsupported bindings
  • Loading branch information
@liquidpele
liquidpele authored Apr 10, 2017
commit 273e545f6f5698c3a7736ffc20944b38ccc65161
7 changes: 6 additions & 1 deletion djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ def csrf_exempt(view_func):
from saml2.metadata import entity_descriptor
from saml2.ident import code, decode
from saml2.sigver import MissingKey
from saml2.s_utils import UnsupportedBinding
from saml2.response import StatusError

from djangosaml2.cache import IdentityCache, OutstandingQueriesCache
Expand Down Expand Up @@ -166,7 +167,11 @@ def login(request,
except TypeError as e:
logger.error('Unable to know which IdP to use')
return HttpResponse(unicode(e))

except UnsupportedBinding as e:
logger.error('%s: sp_authn_requests_signed=%s and dictates the binding chosen, ensure it matches what the IDP metadata allows' % (
e, getattr(conf, '_sp_authn_requests_signed', False)))
raise NotImplementedError('Unsupported binding: %s', binding)

logger.debug('Saving the session_id in the OutstandingQueries cache')
oq_cache = OutstandingQueriesCache(request.session)
oq_cache.set(session_id, came_from)
Expand Down